move Debian param validation to its own code block

Author: shieldwed

manifests/repo/apt.pp

@@ -30,33 +30,33 @@
 ) {
   include 'apt'
 
-  $repo_key_name = $release ? {
-    '3.9'   => '849512C2CA648EF425048F55C883F50CB2289A17',
-    '3.10'  => 'C784DD0FD61E38B8B1F65E10DAD761554A72C1DF',
-    '3.11'  => 'DE82F0BACC4DB70DBEF95CA65EC2255642304A6E',
-    '3.12'  => '8B7C364430B66F0B084C0B0C55339A4C6A7BD8D4',
-    '3.13'  => '9B5AE8E6FD2581F293104ACC38675E5F30F779AF',
-    '4.0'   => '55F839E173AC06F364120D46FA86EEACB306CEE1',
-    '4.1'   => 'EED3351AFD72E5437C050F0388F6CDEE78FA6D97',
-    default => 'F9C958A3AEE0D2184FAD1CBD43607F0DC2F8238C',
-  }
-
-  $repo_key_source = "https://download.gluster.org/pub/gluster/glusterfs/${release}/rsa.pub"
-
-  # basic sanity check
-  if $version == 'LATEST' {
-    $repo_ver = $version
-  } elsif $version =~ /^\d\.\d+$/ {
-    $repo_ver = "${version}/LATEST"
-  } elsif $version =~ /^(\d)\.(\d+)\.(\d+).*$/ {
-    $repo_ver =  "${1}.${2}/${1}.${2}.${3}"
-  } else {
-    fail("${version} doesn't make sense for ${facts['os']['name']}!")
-  }
-
   # the Gluster repo only supports x86_64 (amd64) and arm64. The Ubuntu PPA also supports armhf and arm64.
   case $facts['os']['name'] {
     'Debian': {
+      $repo_key_name = $release ? {
+        '3.9'   => '849512C2CA648EF425048F55C883F50CB2289A17',
+        '3.10'  => 'C784DD0FD61E38B8B1F65E10DAD761554A72C1DF',
+        '3.11'  => 'DE82F0BACC4DB70DBEF95CA65EC2255642304A6E',
+        '3.12'  => '8B7C364430B66F0B084C0B0C55339A4C6A7BD8D4',
+        '3.13'  => '9B5AE8E6FD2581F293104ACC38675E5F30F779AF',
+        '4.0'   => '55F839E173AC06F364120D46FA86EEACB306CEE1',
+        '4.1'   => 'EED3351AFD72E5437C050F0388F6CDEE78FA6D97',
+        default => 'F9C958A3AEE0D2184FAD1CBD43607F0DC2F8238C',
+      }
+
+      $repo_key_source = "https://download.gluster.org/pub/gluster/glusterfs/${release}/rsa.pub"
+
+      # basic sanity check
+      if $version == 'LATEST' {
+        $repo_ver = $version
+      } elsif $version =~ /^\d\.\d+$/ {
+        $repo_ver = "${version}/LATEST"
+      } elsif $version =~ /^(\d)\.(\d+)\.(\d+).*$/ {
+        $repo_ver =  "${1}.${2}/${1}.${2}.${3}"
+      } else {
+        fail("${version} doesn't make sense for ${facts['os']['name']}!")
+      }
+
       case $facts['os']['distro']['codename'] {
         'jessie', 'stretch':  {
           $arch = $facts['os']['architecture'] ? {