Skip to content

Commit d972a64

Browse files
authored
Merge pull request #166 from ekohl/msync-docker
Rely on beaker-hostgenerator for docker nodesets
2 parents a4464e0 + 368754b commit d972a64

File tree

15 files changed

+43
-197
lines changed

15 files changed

+43
-197
lines changed

.github/CONTRIBUTING.md

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,24 @@ you must set an environment variable such as:
4040

4141
export PUPPET_VERSION="~> 4.2.0"
4242

43-
Install the dependencies like so...
43+
You can install all needed gems for spec tests into the modules directory by
44+
running:
4445

45-
bundle install
46+
```sh
47+
bundle install --path .vendor/ --without development --without system_tests --without release
48+
```
49+
50+
If you also want to run acceptance tests:
51+
52+
```sh
53+
bundle install --path .vendor/ --without development --with system_tests --without release
54+
```
55+
56+
Our all in one solution if you don't know if you need to install or update gems:
57+
58+
```sh
59+
bundle install --path .vendor/ --without development --with system_tests --without release; bundle update; bundle clean
60+
```
4661

4762
## Syntax and style
4863

.msync.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
modulesync_config_version: '1.9.0'
1+
modulesync_config_version: '1.9.2'

.sync.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
.travis.yml:
33
docker_sets:
4-
- set: docker/centos-7
5-
- set: docker/debian-9
4+
- set: centos7-64
5+
- set: debian9-64
66
secure: "l2HEhssQyDQGrdBkGS8f/gQ4FA5vVLM0JegyAVaaIXpRrJYgRiDAvC+u81HS//+J0v9cr4jo74ncl1HGU0QJZURJX/L8DJqUVXzSZpe9HmfrQpV1RDUSNMqzaIq5Z268Ou9n1Jkeg58WJyIaks9PQhXoWRRSnaCyDHrbGM8XcAU="

.travis.yml

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,11 @@ sudo: false
33
dist: trusty
44
language: ruby
55
cache: bundler
6+
# related to https://github.com/rubygems/rubygems/issues/2123
67
before_install:
7-
- rm -f Gemfile.lock
8+
- 'rm -f Gemfile.lock'
9+
- 'gem update --system'
10+
- 'gem install bundler'
811
script:
912
- 'bundle exec rake $CHECK'
1013
matrix:
@@ -13,28 +16,28 @@ matrix:
1316
- rvm: 2.1.9
1417
bundler_args: --without system_tests development release
1518
env: PUPPET_VERSION="~> 4.0" CHECK=test PARALLEL_TEST_PROCESSORS=12
16-
- rvm: 2.4.3
19+
- rvm: 2.4.4
1720
bundler_args: --without system_tests development release
18-
env: PUPPET_VERSION="~> 5.0" CHECK=test_with_coveralls
19-
- rvm: 2.5.0
21+
env: PUPPET_VERSION="~> 5.0" CHECK=test
22+
- rvm: 2.5.1
2023
bundler_args: --without system_tests development release
2124
env: PUPPET_VERSION="~> 5.0" CHECK=test_with_coveralls
22-
- rvm: 2.4.3
25+
- rvm: 2.4.4
2326
bundler_args: --without system_tests development release
2427
env: PUPPET_VERSION="~> 5.0" CHECK=rubocop
25-
- rvm: 2.4.3
28+
- rvm: 2.5.1
2629
bundler_args: --without system_tests development release
2730
env: PUPPET_VERSION="~> 5.0" CHECK=build DEPLOY_TO_FORGE=yes
28-
- rvm: 2.4.3
31+
- rvm: 2.5.1
2932
bundler_args: --without development release
3033
dist: trusty
31-
env: PUPPET_INSTALL_TYPE=agent BEAKER_debug=true BEAKER_set=docker/centos-7 CHECK=beaker
34+
env: PUPPET_INSTALL_TYPE=agent BEAKER_debug=true BEAKER_setfile=centos7-64{hypervisor=docker} CHECK=beaker
3235
services: docker
3336
sudo: required
34-
- rvm: 2.4.3
37+
- rvm: 2.5.1
3538
bundler_args: --without development release
3639
dist: trusty
37-
env: PUPPET_INSTALL_TYPE=agent BEAKER_debug=true BEAKER_set=docker/debian-9 CHECK=beaker
40+
env: PUPPET_INSTALL_TYPE=agent BEAKER_debug=true BEAKER_setfile=debian9-64{hypervisor=docker} CHECK=beaker
3841
services: docker
3942
sudo: required
4043
branches:

Gemfile

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ group :test do
2525
gem 'redcarpet', :require => false
2626
gem 'rubocop', '~> 0.49.1', :require => false if RUBY_VERSION >= '2.3.0'
2727
gem 'rubocop-rspec', '~> 1.15.0', :require => false if RUBY_VERSION >= '2.3.0'
28-
gem 'mocha', '>= 1.2.1', :require => false
28+
gem 'mocha', '~> 1.4.0', :require => false
2929
gem 'coveralls', :require => false
3030
gem 'simplecov-console', :require => false
3131
gem 'rack', '~> 1.0', :require => false if RUBY_VERSION < '2.2.2'
@@ -40,7 +40,7 @@ group :development do
4040
end
4141

4242
group :system_tests do
43-
gem 'winrm', :require => false
43+
gem 'winrm', :require => false
4444
if beaker_version = ENV['BEAKER_VERSION']
4545
gem 'beaker', *location_for(beaker_version)
4646
else
@@ -51,9 +51,10 @@ group :system_tests do
5151
else
5252
gem 'beaker-rspec', :require => false
5353
end
54-
gem 'serverspec', :require => false
55-
gem 'beaker-puppet_install_helper', :require => false
56-
gem 'beaker-module_install_helper', :require => false
54+
gem 'serverspec', :require => false
55+
gem 'beaker-hostgenerator', '>= 1.1.10', :require => false
56+
gem 'beaker-puppet_install_helper', :require => false
57+
gem 'beaker-module_install_helper', :require => false
5758
end
5859

5960
group :release do

spec/acceptance/nodesets/docker/centos-5.yml

Lines changed: 0 additions & 19 deletions
This file was deleted.

spec/acceptance/nodesets/docker/centos-6.yml

Lines changed: 0 additions & 20 deletions
This file was deleted.

spec/acceptance/nodesets/docker/centos-7.yml

Lines changed: 0 additions & 19 deletions
This file was deleted.

spec/acceptance/nodesets/docker/debian-7.yml

Lines changed: 0 additions & 18 deletions
This file was deleted.

spec/acceptance/nodesets/docker/debian-8.yml

Lines changed: 0 additions & 20 deletions
This file was deleted.

0 commit comments

Comments
 (0)