Rely on puppetlabs-apt to handle https transport

Author: ekohl

manifests/repo/apt.pp

@@ -37,8 +37,6 @@
 ) {
   include '::apt'
 
-  ensure_packages(['apt-transport-https'], {'ensure' => 'present'})
-
   # Key has changed since 3.9
   $repo_key_name = $release ? {
     '3.8'                                     => 'A4703C37D3F4DE7F1819E980FE79BB52D5DC52DC',
@@ -78,9 +76,9 @@
             default      => false,
           }
           if versioncmp($release, '3.12') < 0 {
-            $repo_url  = "http://download.gluster.org/pub/gluster/glusterfs/${release}/LATEST/Debian/${::lsbdistcodename}/apt/"
+            $repo_url  = "https://download.gluster.org/pub/gluster/glusterfs/${release}/LATEST/Debian/${::lsbdistcodename}/apt/"
           } else {
-            $repo_url  = "http://download.gluster.org/pub/gluster/glusterfs/${release}/LATEST/Debian/${::lsbdistcodename}/${arch}/apt/"
+            $repo_url  = "https://download.gluster.org/pub/gluster/glusterfs/${release}/LATEST/Debian/${::lsbdistcodename}/${arch}/apt/"
           }
         }
       }

metadata.json

@@ -40,7 +40,7 @@
   "dependencies": [
     {
       "name": "puppetlabs/apt",
-      "version_requirement": ">= 2.1.0 < 7.0.0"
+      "version_requirement": ">= 4.4.0 < 7.0.0"
     },
     {
       "name": "puppetlabs/stdlib",

spec/classes/init_spec.rb

@@ -69,7 +69,6 @@
         context 'Debian specific stuff' do
           it { is_expected.to contain_class('gluster::repo::apt') }
           it { is_expected.to contain_apt__source('glusterfs-LATEST') }
-          it { is_expected.to contain_package('apt-transport-https') }
           it 'creates gluster::install' do
             is_expected.to create_class('gluster::install').with(
               server: true,

spec/classes/repo_apt_spec.rb

@@ -19,7 +19,7 @@
             is_expected.to contain_apt__source('glusterfs-LATEST').with(
               repos: 'main',
               release: facts[:lsbdistcodename].to_s,
-              location: "http://download.gluster.org/pub/gluster/glusterfs/3.12/LATEST/Debian/#{facts[:lsbdistcodename]}/#{facts[:architecture]}/apt/"
+              location: "https://download.gluster.org/pub/gluster/glusterfs/3.12/LATEST/Debian/#{facts[:lsbdistcodename]}/#{facts[:architecture]}/apt/"
             )
           end
         end
@@ -47,7 +47,7 @@
             is_expected.to contain_apt__source('glusterfs-LATEST').with(
               repos: 'main',
               release: facts[:lsbdistcodename].to_s,
-              location: "http://download.gluster.org/pub/gluster/glusterfs/3.12/LATEST/Debian/#{facts[:lsbdistcodename]}/#{facts[:architecture]}/apt/",
+              location: "https://download.gluster.org/pub/gluster/glusterfs/3.12/LATEST/Debian/#{facts[:lsbdistcodename]}/#{facts[:architecture]}/apt/",
               pin: '700'
             )
           end
@@ -68,7 +68,7 @@
                 'id' => '849512C2CA648EF425048F55C883F50CB2289A17',
                 'key_source' => 'https://download.gluster.org/pub/gluster/glusterfs/3.9/rsa.pub'
               },
-              location: "http://download.gluster.org/pub/gluster/glusterfs/3.9/LATEST/Debian/#{facts[:lsbdistcodename]}/apt/"
+              location: "https://download.gluster.org/pub/gluster/glusterfs/3.9/LATEST/Debian/#{facts[:lsbdistcodename]}/apt/"
             )
           end
         end