Merge pull request #282 from ekohl/reduce-acceptance-test-duplication

Reduce acceptance test duplication

Author: ekohl

spec/acceptance/hieradata/common.yaml

@@ -0,0 +1,4 @@
+---
+letsencrypt::email: '[email protected]'
+letsencrypt::config:
+  server: 'https://acme-staging-v02.api.letsencrypt.org/directory'

spec/acceptance/letsencrypt_plugin_dns_cloudflare_spec.rb

@@ -6,12 +6,7 @@
   it_behaves_like 'an idempotent resource' do
     let(:manifest) do
       <<-PUPPET
-      class { 'letsencrypt' :
-        email  => '[email protected]',
-        config => {
-          'server' => 'https://acme-staging-v02.api.letsencrypt.org/directory',
-        },
-      }
+      include letsencrypt
       class { 'letsencrypt::plugin::dns_cloudflare':
         api_token => 'dummy-cloudflare-api-token',
       }

spec/acceptance/letsencrypt_plugin_dns_rfc2136_spec.rb

@@ -3,34 +3,23 @@
 require 'spec_helper_acceptance'
 
 describe 'letsencrypt::plugin::dns_rfc2136' do
-  context 'with defaults values' do
-    pp = <<-PUPPET
-      class { 'letsencrypt' :
-        email  => '[email protected]',
-        config => {
-          'server' => 'https://acme-staging-v02.api.letsencrypt.org/directory',
-        },
-      }
+  it_behaves_like 'an idempotent resource' do
+    let(:manifest) do
+      <<-PUPPET
+      include letsencrypt
       class { 'letsencrypt::plugin::dns_rfc2136':
         server     => '192.0.2.1',
         key_name   => 'certbot',
         key_secret => 'secret',
       }
-    PUPPET
-
-    it 'installs letsencrypt and dns rfc2136 plugin without error' do
-      apply_manifest(pp, catch_failures: true)
-    end
-
-    it 'installs letsencrypt and dns rfc2136 idempotently' do
-      apply_manifest(pp, catch_changes: true)
+      PUPPET
     end
+  end
 
-    describe file('/etc/letsencrypt/dns-rfc2136.ini') do
-      it { is_expected.to be_file }
-      it { is_expected.to be_owned_by 'root' }
-      it { is_expected.to be_grouped_into 'root' }
-      it { is_expected.to be_mode 400 }
-    end
+  describe file('/etc/letsencrypt/dns-rfc2136.ini') do
+    it { is_expected.to be_file }
+    it { is_expected.to be_owned_by 'root' }
+    it { is_expected.to be_grouped_into 'root' }
+    it { is_expected.to be_mode 400 }
   end
 end

spec/acceptance/letsencrypt_plugin_dns_route53_spec.rb

@@ -3,24 +3,12 @@
 require 'spec_helper_acceptance'
 
 describe 'letsencrypt::plugin::dns_route53' do
-  context 'with defaults values' do
-    pp = <<-PUPPET
-      class { 'letsencrypt' :
-        email  => '[email protected]',
-        config => {
-          'server' => 'https://acme-staging-v02.api.letsencrypt.org/directory',
-        },
-      }
-      class { 'letsencrypt::plugin::dns_route53':
-      }
-    PUPPET
-
-    it 'installs letsencrypt and dns route53 plugin without error' do
-      apply_manifest(pp, catch_failures: true)
-    end
-
-    it 'installs letsencrypt and dns route53 idempotently' do
-      apply_manifest(pp, catch_changes: true)
+  it_behaves_like 'an idempotent resource' do
+    let(:manifest) do
+      <<-PUPPET
+      include letsencrypt
+      include letsencrypt::plugin::dns_route53
+      PUPPET
     end
   end
 end

spec/acceptance/letsencrypt_plugin_nginx_spec.rb

@@ -3,24 +3,12 @@
 require 'spec_helper_acceptance'
 
 describe 'letsencrypt::plugin::nginx' do
-  context 'with default values' do
-    pp = <<-PUPPET
-      class { 'letsencrypt' :
-        email  => '[email protected]',
-        config => {
-          'server' => 'https://acme-staging.api.letsencrypt.org/directory',
-        },
-      }
-      class { 'letsencrypt::plugin::nginx':
-      }
-    PUPPET
-
-    it 'installs letsencrypt and nginx plugin without error' do
-      apply_manifest(pp, catch_failures: true)
-    end
-
-    it 'installs letsencrypt and nginx idempotently' do
-      apply_manifest(pp, catch_changes: true)
+  it_behaves_like 'an idempotent resource' do
+    let(:manifest) do
+      <<-PUPPET
+      include letsencrypt
+      include letsencrypt::plugin::nginx
+      PUPPET
     end
   end
 end

spec/acceptance/letsencrypt_spec.rb

@@ -4,21 +4,8 @@
 
 describe 'letsencrypt' do
   context 'with defaults values' do
-    pp = %(
-      class { 'letsencrypt' :
-        email  => '[email protected]',
-        config => {
-          'server' => 'https://acme-staging-v02.api.letsencrypt.org/directory',
-        },
-      }
-    )
-
-    it 'installs letsencrypt without error' do
-      apply_manifest(pp, catch_failures: true)
-    end
-
-    it 'installs letsencrypt idempotently' do
-      apply_manifest(pp, catch_changes: true)
+    it_behaves_like 'an idempotent resource' do
+      let(:manifest) { 'include letsencrypt' }
     end
 
     describe file('/etc/letsencrypt/cli.ini') do