Does not support 1.12

[nhinds]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: 3.8.7
• Ruby: 2.0.0p648
• Module version: 2fa4615 (current master)

How to reproduce (e.g Puppet code you use)

class { minecraft: source => "1.12", manage_java => false }

or

class { minecraft: source => "1.12.0", manage_java => false }

What are you seeing

When passing "1.12" as the version, the catalog does not compile:

Error: Parameter source failed on Archive[minecraft_server]: invalid source url: 1.12 at /path/to/minecraft/manifests/source.pp:28

When passing "1.12.0" as the version, minecraft fails to download:

Error: Execution of '/usr/bin/curl https://s3.amazonaws.com/Minecraft.Download/versions/1.12.0/minecraft_server.1.12.0.jar -o /tmp/minecraft_server.jar_20170607-21319-1ym2ifx -fsSL --max-redirs 5' returned 22: curl: (22) The requested URL returned error: 403 Forbidden

What behaviour did you expect instead

Successfully downloading and installing the 1.12 server jar from https://s3.amazonaws.com/Minecraft.Download/versions/1.12/minecraft_server.1.12.jar

Output log

$ puppet apply --modulepath modules -e 'class { minecraft: source => "1.12", manage_java => false }' --noop
Notice: Compiled catalog for <machine name> in environment production in 0.37 seconds
Error: Parameter source failed on Archive[minecraft_server]: invalid source url: 1.12 at <path>/minecraft/manifests/source.pp:28

Any additional information you'd like to impart

Looks like the regex for minecraft versions in source.pp only allows three-part versions like 1.11.2, but the latest minecraft version is just called 1.12 in its S3 URL