Fix legacy facts

Author: dhoppe

examples/sharding.pp

@@ -5,11 +5,11 @@
   }
   -> class {'mongodb::server':
     configsvr => true,
-    bind_ip   => [$::ipaddress],
+    bind_ip   => [$facts['networking']['ip']],
   }
   -> class {'mongodb::client': }
   -> class {'mongodb::mongos':
-    configdb => ["${::ipaddress}:27019"],
+    configdb => ["${facts['networking']['ip']}:27019"],
   }
   -> mongodb_shard { 'rs1' :
     member => 'rs1/mongod1:27018',
@@ -30,7 +30,7 @@
   -> class {'mongodb::server':
     shardsvr => true,
     replset  => 'rs1',
-    bind_ip  => [$::ipaddress],
+    bind_ip  => [$facts['networking']['ip']],
   }
   -> class {'mongodb::client': }
   mongodb_replset{'rs1':
@@ -46,7 +46,7 @@
   -> class {'mongodb::server':
     shardsvr => true,
     replset  => 'rs1',
-    bind_ip  => [$::ipaddress],
+    bind_ip  => [$facts['networking']['ip']],
   }
   -> class {'mongodb::client': }
   mongodb_replset{'rs1':

manifests/client/params.pp

@@ -6,7 +6,7 @@
   if $manage_package {
     $package_name = "mongodb-${mongodb::globals::edition}-shell"
   } else {
-    $package_name = $::osfamily ? {
+    $package_name = $facts['os']['family'] ? {
       'Debian' => 'mongodb-clients',
       default  => 'mongodb',
     }

manifests/mongos/params.pp

@@ -27,7 +27,7 @@
   $service_status = undef
 
   # Amazon Linux's OS Family is 'Linux', operating system 'Amazon'.
-  case $::osfamily {
+  case $facts['os']['family'] {
     'RedHat', 'Linux', 'Suse': {
       if $manage_package {
         $config           = '/etc/mongodb-shard.conf'
@@ -53,7 +53,7 @@
       $fork             = undef
     }
     default: {
-      fail("Osfamily ${::osfamily} is not supported")
+      fail("Osfamily ${facts['os']['family']} is not supported")
     }
   }
 }

manifests/opsmanager.pp

@@ -32,7 +32,7 @@
   String[1] $service_name                        = 'mongodb-mms',
   Stdlib::Httpurl $download_url                  = 'https://downloads.mongodb.com/on-prem-mms/rpm/mongodb-mms-4.0.1.50101.20180801T1117Z-1.x86_64.rpm',
   String[1] $mongo_uri                           = 'mongodb://127.0.0.1:27017',
-  Stdlib::Httpurl $opsmanager_url                = "http://${facts['fqdn']}:8080",
+  Stdlib::Httpurl $opsmanager_url                = "http://${facts['networking']['fqdn']}:8080",
   String[1] $client_certificate_mode             = 'None',
   String[1] $from_email_addr                     = '[email protected]',
   String[1] $reply_to_email_addr                 = '[email protected]',

manifests/params.pp

@@ -38,7 +38,7 @@
   }
 
   # Amazon Linux's OS Family is 'Linux', operating system 'Amazon'.
-  case $::osfamily {
+  case $facts['os']['family'] {
     'RedHat', 'Linux', 'Suse': {
       if $manage_package {
         $user                    = pick($mongodb::globals::user, 'mongod')
@@ -79,7 +79,7 @@
       $journal                 = undef
     }
     default: {
-      fail("Osfamily ${::osfamily} is not supported")
+      fail("Osfamily ${facts['os']['family']} is not supported")
     }
   }
 }

manifests/repo.pp

@@ -9,7 +9,7 @@
   Optional[String] $proxy_password                    = undef,
   Optional[String[1]] $aptkey_options                 = undef,
 ) {
-  case $::osfamily {
+  case $facts['os']['family'] {
     'RedHat', 'Linux': {
       if $repo_location != undef {
         $location = $repo_location
@@ -45,13 +45,13 @@
         }
 
         $mongover = split($version, '[.]')
-        $location = $::operatingsystem ? {
+        $location = $facts['os']['name'] ? {
           'Debian' => "https://${repo_domain}/apt/debian",
           'Ubuntu' => "https://${repo_domain}/apt/ubuntu",
           default  => undef
         }
-        $release     = "${::lsbdistcodename}/${repo_path}/${mongover[0]}.${mongover[1]}"
-        $repos       = $::operatingsystem ? {
+        $release     = "${facts['os']['distro']['codename']}/${repo_path}/${mongover[0]}.${mongover[1]}"
+        $repos       = $facts['os']['name'] ? {
           'Debian' => 'main',
           'Ubuntu' => 'multiverse',
           default => undef
@@ -70,7 +70,7 @@
 
     default: {
       if($ensure == 'present' or $ensure == true) {
-        fail("Unsupported managed repository for osfamily: ${::osfamily}, operatingsystem: ${::operatingsystem}, module ${module_name} currently only supports managing repos for osfamily RedHat, Debian and Ubuntu")
+        fail("Unsupported managed repository for osfamily: ${facts['os']['family']}, operatingsystem: ${facts['os']['name']}, module ${module_name} currently only supports managing repos for osfamily RedHat, Debian and Ubuntu")
       }
     }
   }