Refactor opsmanager handling

This removes the trivial private classes in favor of doing it all in the
main class. This also means moving all params into the main class which
has the side effect that the REFERENCE.md will be much more useful when
generated.

Author: ekohl

README.md

@@ -161,7 +161,6 @@ and then set the emails later.
 
 Most of the interaction for the server is done via `mongodb::opsmanager`. For
 more options please have a look at [mongodb::opsmanager](#class-mongodbopsmanager).
-There are also some settings that can be configured in `mongodb::globals`.
 
 ## Reference
 
@@ -185,8 +184,6 @@ There are also some settings that can be configured in `mongodb::globals`.
 * `mongodb::mongos::config`: Configures Mongos configuration files
 * `mongodb::mongos::install`: Install Mongos software packages
 * `mongodb::mongos::service`: Manages Mongos service
-* `mongodb::opsmanager::install` : Install Ops Manager software package
-* `mongodb::opsmanager::service` : Manages Ops Manager (mongodb-mms) service
 
 #### Class: mongodb::globals
 *Note:* most server specific defaults should be overridden in the `mongodb::server`
@@ -654,22 +651,6 @@ Plain-text user password (will be hashed)
 ##### `roles`
 Array with user roles. Default: ['dbAdmin']
 
-##### `opsmanager_url`
-The fully qualified url where opsmanager runs. Must include the port. Ex:
-'http://opsmanager.yourdomain.com:8080'
-
-##### `opsmanager_mongo_uri`
-Full URI where the Ops Manager application mongodb server(s) can be found. Default: 'mongodb://127.0.0.1:27017'
-
-##### `ca_file`
-Ca file for secure connection to backup agents.
-
-##### `pem_key_file`
-Pem key file containing the cert and private key used for secure connections to backup agents.
-
-##### `pem_key_password`
-The password to the pem key file.
-
 ### Providers
 
 #### Provider: mongodb_database

manifests/opsmanager.pp

@@ -1,17 +1,38 @@
-# This installs Ops Manager. See README.md for more info.
-
+# This installs Ops Manager
+#
+# @param user
+#   The user that owns the config file
+#
+# @param group
+#   The group that owns the config file
+#
+# @param opsmanager_url
+#   The fully qualified url where opsmanager runs. Must include the port.
+#
+# @param opsmanager_mongo_uri
+#   Full URI where the Ops Manager application mongodb server(s) can be found.
+#
+# @param ca_file
+#   Ca file for secure connection to backup agents.
+#
+# @param pem_key_file
+#   Pem key file containing the cert and private key used for secure connections to backup agents.
+#
+# @param pem_key_password
+#   The password to the pem key file.
+#
 class mongodb::opsmanager (
-  String[1] $user                                = $mongodb::opsmanager::params::user,
-  String[1] $group                               = $mongodb::opsmanager::params::group,
-  Enum['running', 'stopped'] $ensure             = $mongodb::opsmanager::params::ensure,
-  String[1] $package_name                        = $mongodb::opsmanager::params::package_name,
-  String[1] $package_ensure                      = $mongodb::opsmanager::params::package_ensure,
-  Boolean $service_enable                        = $mongodb::opsmanager::params::service_enable,
-  Boolean $service_manage                        = $mongodb::opsmanager::params::service_manage,
-  String[1] $service_name                        = $mongodb::opsmanager::params::service_name,
-  Stdlib::Httpurl $download_url                  = $mongodb::opsmanager::params::download_url,
-  String[1] $mongo_uri                           = $mongodb::opsmanager::params::mongo_uri,
-  Stdlib::Httpurl $opsmanager_url                = $mongodb::opsmanager::params::opsmanager_url,
+  String[1] $user                                = 'mongodb-mms',
+  String[1] $group                               = 'mongodb-mms',
+  Enum['running', 'stopped'] $ensure             = 'running',
+  String[1] $package_name                        = 'mongodb-mms',
+  String[1] $package_ensure                      = 'present',
+  Boolean $service_enable                        = true,
+  Boolean $service_manage                        = true,
+  String[1] $service_name                        = 'mongodb-mms',
+  Stdlib::Httpurl $download_url                  = 'https://downloads.mongodb.com/on-prem-mms/rpm/mongodb-mms-4.0.1.50101.20180801T1117Z-1.x86_64.rpm',
+  String[1] $mongo_uri                           = 'mongodb://127.0.0.1:27017',
+  Stdlib::Httpurl $opsmanager_url                = "http://${facts['fqdn']}:8080",
   String[1] $client_certificate_mode             = 'None',
   String[1] $from_email_addr                     = '[email protected]',
   String[1] $reply_to_email_addr                 = '[email protected]',
@@ -23,30 +44,59 @@
   Boolean $ssl                                   = false,
   Boolean $ignore_ui_setup                       = true,
   #optional settings
-  Optional[String[1]] $ca_file                   = $mongodb::opsmanager::params::ca_file,
-  Optional[String[1]] $pem_key_file              = $mongodb::opsmanager::params::pem_key_file,
-  Optional[String[1]] $pem_key_password          = $mongodb::opsmanager::params::pem_key_password,
+  Optional[String[1]] $ca_file                   = undef,
+  Optional[String[1]] $pem_key_file              = undef,
+  Optional[String[1]] $pem_key_password          = undef,
   Optional[String[1]] $user_svc_class            = undef, # Default: com.xgen.svc.mms.svc.user.UserSvcDb External Source: com.xgen.svc.mms.svc.user.UserSvcCrowd or Internal Database: com.xgen.svc.mms.svc.user.UserSvcDb
   Optional[Integer] $snapshot_interval           = undef, # Default: 24
   Optional[Integer] $snapshot_interval_retention = undef, # Default: 2
   Optional[Integer] $snapshot_daily_retention    = undef, # Default: 0
   Optional[Integer] $snapshot_weekly_retention   = undef, # Default: 2
   Optional[Integer] $snapshot_monthly_retention  = undef, # Default: 1
   Optional[Integer] $versions_directory          = undef, # Linux default: /opt/mongodb/mms/mongodb-releases/
+) {
+
+  case $package_ensure {
+    'absent': {
+      $my_package_ensure = 'absent'
+      $file_ensure       = 'absent'
+    }
+    default:  {
+      $my_package_ensure = $package_ensure
+      $file_ensure       = 'present'
+    }
+  }
+
+  $config_file = '/opt/mongodb/mms/conf/conf-mms.properties'
 
-  ) inherits mongodb::opsmanager::params {
+  package { $package_name:
+    ensure => $my_package_ensure,
+    source => $download_url,
+  }
+
+  file { $config_file:
+    ensure  => $file_ensure,
+    owner   => $user,
+    group   => $group,
+    mode    => '0640',
+    content => epp('mongodb/opsmanager/conf-mms.properties.epp'),
+  }
 
-  contain mongodb::opsmanager::install
-  contain mongodb::opsmanager::config
-  contain mongodb::opsmanager::service
+  if $service_manage {
+    service { $service_name:
+      ensure => $ensure,
+      enable => $service_enable,
+    }
+  }
 
-  if ($mongo_uri == 'mongodb://127.0.0.1:27017') {
+  if $mongo_uri == 'mongodb://127.0.0.1:27017' {
     include mongodb::server
   }
 
-  if ($ensure == 'running') {
-    Class['mongodb::opsmanager::install']
-    ~> Class['mongodb::opsmanager::config']
-    ~> Class['mongodb::opsmanager::service']
+  if $ensure == 'running' {
+    Package[$package_name] -> File[$config_file]
+    if $service_manage {
+      [Package[$package_name], File[$config_file]] ~> Service[$service_name]
+    }
   }
 }

manifests/opsmanager/config.pp

@@ -0,0 +1,37 @@
+require 'spec_helper'
+
+describe 'mongodb::opsmanager' do
+  on_supported_os.each do |os, facts|
+    context "on #{os}" do
+      let(:facts) { facts }
+
+      let(:params) do
+        {
+          opsmanager_url: 'http://localhost:8080'
+        }
+      end
+
+      describe 'with defaults' do
+        it { is_expected.to compile.with_all_deps }
+
+        it { is_expected.to contain_service('mongodb') }
+
+        it do
+          is_expected.to create_package('mongodb-mms').
+            with_ensure('present')
+        end
+
+        it do
+          is_expected.to contain_file('/opt/mongodb/mms/conf/conf-mms.properties').
+            with_ensure('file').
+            that_requires('Package[mongodb-mms]')
+        end
+
+        it do
+          is_expected.to contain_service('mongodb-mms').
+            that_subscribes_to(['Package[mongodb-mms]', 'File[/opt/mongodb/mms/conf/conf-mms.properties]'])
+        end
+      end
+    end
+  end
+end