Rubocop: correct message spies

Author: ekohl

spec/unit/puppet/provider/mongodb_database/mongodb_spec.rb

@@ -48,15 +48,17 @@
 
   describe 'create' do
     it 'makes a database' do
-      expect(provider).to receive(:mongo_eval)
+      allow(provider).to receive(:mongo_eval)
       provider.create
+      expect(provider).to have_received(:mongo_eval)
     end
   end
 
   describe 'destroy' do
     it 'removes a database' do
-      expect(provider).to receive(:mongo_eval)
+      allow(provider).to receive(:mongo_eval)
       provider.destroy
+      expect(provider).to have_received(:mongo_eval)
     end
   end
 

spec/unit/puppet/provider/mongodb_replset/mongodb_spec.rb

@@ -39,13 +39,19 @@
 
     # rubocop:disable RSpec/MultipleExpectations
     it 'creates a replicaset' do
-      expect(provider.class).to receive(:replset_properties)
-      expect(provider).to receive(:get_hosts_status).and_return([valid_members, []])
-      expect(provider).to receive(:master_host).and_return(false)
-      expect(provider).to receive(:rs_initiate).with('{"_id":"rs_test","members":[{"host":"mongo1:27017","_id":0},{"host":"mongo2:27017","_id":1},{"host":"mongo3:27017","_id":2}],"settings":{}}', 'mongo1:27017').and_return('info' => 'Config now saved locally.  Should come online in about a minute.', 'ok' => 1)
-      expect(provider).to receive(:db_ismaster).and_return('{"ismaster" : true}')
+      allow(provider.class).to receive(:replset_properties)
+      allow(provider).to receive(:get_hosts_status).and_return([valid_members, []])
+      allow(provider).to receive(:master_host).and_return(false)
+      allow(provider).to receive(:rs_initiate).with('{"_id":"rs_test","members":[{"host":"mongo1:27017","_id":0},{"host":"mongo2:27017","_id":1},{"host":"mongo3:27017","_id":2}],"settings":{}}', 'mongo1:27017').and_return('info' => 'Config now saved locally.  Should come online in about a minute.', 'ok' => 1)
+      allow(provider).to receive(:db_ismaster).and_return('{"ismaster" : true}')
       provider.create
       provider.flush
+
+      expect(provider.class).to have_received(:replset_properties)
+      expect(provider).to have_received(:get_hosts_status)
+      expect(provider).to have_received(:master_host)
+      expect(provider).to have_received(:rs_initiate)
+      expect(provider).to have_received(:db_ismaster)
     end
     # rubocop:enable RSpec/MultipleExpectations
   end
@@ -145,9 +151,10 @@
     it 'adds missing members to an existing replicaset' do
       allow(provider.class).to receive(:replset_properties)
       allow(provider).to receive(:rs_status).and_return('set' => 'rs_test')
-      expect(provider).to receive('rs_add').thrice.and_return('ok' => 1)
+      allow(provider).to receive('rs_add').thrice.and_return('ok' => 1)
       provider.members = valid_members
       provider.flush
+      expect(provider).to have_received('rs_add').thrice
     end
 
     it 'raises an error when the master host is not available' do

spec/unit/puppet/provider/mongodb_shard/mongodb_spec.rb

@@ -50,15 +50,18 @@
   describe '#create' do
     # rubocop:disable RSpec/MultipleExpectations
     it 'makes a shard' do
-      expect(provider).to receive(:sh_addshard).with('rs_test/mongo1:27018').and_return(
+      allow(provider).to receive(:sh_addshard).with('rs_test/mongo1:27018').and_return(
         'shardAdded' => 'rs_test',
         'ok' => 1
       )
-      expect(provider).to receive(:sh_enablesharding).with('rs_test').and_return(
+      allow(provider).to receive(:sh_enablesharding).with('rs_test').and_return(
         'ok' => 1
       )
       provider.create
       provider.flush
+
+      expect(provider).to have_received(:sh_addshard)
+      expect(provider).to have_received(:sh_enablesharding)
     end
     # rubocop:enable RSpec/MultipleExpectations
   end

spec/unit/puppet/provider/mongodb_user/mongodb_spec.rb

@@ -61,15 +61,17 @@
       }
       EOS
 
-      expect(provider).to receive(:mongo_eval).with("db.runCommand(#{cmd_json})", 'new_database')
+      allow(provider).to receive(:mongo_eval).with("db.runCommand(#{cmd_json})", 'new_database')
       provider.create
+      expect(provider).to have_received(:mongo_eval)
     end
   end
 
   describe 'destroy' do
     it 'removes a user' do
-      expect(provider).to receive(:mongo_eval).with('db.dropUser("new_user")')
+      allow(provider).to receive(:mongo_eval).with('db.dropUser("new_user")')
       provider.destroy
+      expect(provider).to have_received(:mongo_eval)
     end
   end
 
@@ -94,9 +96,10 @@
           "digestPassword":false
       }
       EOS
-      expect(provider).to receive(:mongo_eval).
+      allow(provider).to receive(:mongo_eval).
         with("db.runCommand(#{cmd_json})", 'new_database')
       provider.password_hash = 'newpass'
+      expect(provider).to have_received(:mongo_eval)
     end
   end
 
@@ -121,34 +124,37 @@
   describe 'roles=' do
     it 'changes nothing' do
       resource.provider.set(name: 'new_user', ensure: :present, roles: %w[role1 role2@other_database])
-      expect(provider).not_to receive(:mongo_eval)
+      allow(provider).to receive(:mongo_eval)
       provider.roles = %w[role1 role2@other_database]
+      expect(provider).not_to have_received(:mongo_eval)
     end
 
     it 'grant a role' do
       resource.provider.set(name: 'new_user', ensure: :present, roles: %w[role1 role2@other_database])
-      expect(provider).to receive(:mongo_eval).
+      allow(provider).to receive(:mongo_eval).
         with('db.getSiblingDB("new_database").grantRolesToUser("new_user", [{"role":"role3","db":"new_database"}])')
       provider.roles = %w[role1 role2@other_database role3]
+      expect(provider).to have_received(:mongo_eval)
     end
 
     it 'revokes a role' do
       resource.provider.set(name: 'new_user', ensure: :present, roles: %w[role1 role2@other_database])
-      expect(provider).to receive(:mongo_eval).
+      allow(provider).to receive(:mongo_eval).
         with('db.getSiblingDB("new_database").revokeRolesFromUser("new_user", [{"role":"role1","db":"new_database"}])')
       provider.roles = ['role2@other_database']
+      expect(provider).to have_received(:mongo_eval)
     end
 
-    # rubocop:disable RSpec/MultipleExpectations
     it 'exchanges a role' do
       resource.provider.set(name: 'new_user', ensure: :present, roles: %w[role1 role2@other_database])
-      expect(provider).to receive(:mongo_eval).
+      allow(provider).to receive(:mongo_eval).
         with('db.getSiblingDB("new_database").revokeRolesFromUser("new_user", [{"role":"role1","db":"new_database"}])')
-      expect(provider).to receive(:mongo_eval).
+      allow(provider).to receive(:mongo_eval).
         with('db.getSiblingDB("new_database").grantRolesToUser("new_user", [{"role":"role3","db":"new_database"}])')
 
       provider.roles = %w[role2@other_database role3]
+
+      expect(provider).to have_received(:mongo_eval).twice
     end
-    # rubocop:enable RSpec/MultipleExpectations
   end
 end