Fix a dependency cycle caused by Apt::Source from puppetlabs-apt 6.3.0 (#528)

Tag the package resources with `mongodb_package`

Author: thaiphv

manifests/client.pp

@@ -14,6 +14,6 @@
   package { 'mongodb_client':
     ensure => $ensure,
     name   => $package_name,
-    tag    => 'mongodb',
+    tag    => 'mongodb_package',
   }
 }

manifests/mongos/install.pp

@@ -8,6 +8,7 @@
     package { 'mongodb_mongos':
       ensure => $package_ensure,
       name   => $package_name,
+      tag    => 'mongodb_package',
     }
   }
 

manifests/repo/apt.pp

@@ -17,7 +17,7 @@
       },
     }
 
-    Apt::Source['mongodb']->Package<|tag == 'mongodb'|>
+    Apt::Source['mongodb'] -> Package<| tag == 'mongodb_package' |>
   }
   else {
     apt::source { 'mongodb':

manifests/repo/yum.pp

@@ -13,7 +13,7 @@
       proxy_username => $mongodb::repo::proxy_username,
       proxy_password => $mongodb::repo::proxy_password,
     }
-    Yumrepo['mongodb'] -> Package<|tag == 'mongodb'|>
+    Yumrepo['mongodb'] -> Package<| tag == 'mongodb_package' |>
   }
   else {
     yumrepo { 'mongodb':

manifests/server/install.pp

@@ -29,6 +29,6 @@
   package { 'mongodb_server':
     ensure => $my_package_ensure,
     name   => $package_name,
-    tag    => 'mongodb',
+    tag    => 'mongodb_package',
   }
 }

spec/classes/client_spec.rb

@@ -16,7 +16,7 @@
         end
 
         it { is_expected.to compile.with_all_deps }
-        it { is_expected.to create_package('mongodb_client').with_ensure('present').with_name('mongodb-org-shell') }
+        it { is_expected.to create_package('mongodb_client').with_ensure('present').with_name('mongodb-org-shell').with_tag('mongodb_package') }
       end
     end
   end

spec/classes/mongos_spec.rb

@@ -18,7 +18,7 @@
 
         # install
         it { is_expected.to contain_class('mongodb::mongos::install') }
-        it { is_expected.to contain_package('mongodb_mongos').with_ensure('present').with_name('mongodb-server') }
+        it { is_expected.to contain_package('mongodb_mongos').with_ensure('present').with_name('mongodb-server').with_tag('mongodb_package') }
 
         # config
         it { is_expected.to contain_class('mongodb::mongos::config') }
@@ -68,7 +68,7 @@
         end
 
         it { is_expected.to compile.with_all_deps }
-        it { is_expected.to contain_package('mongodb_mongos').with_name('mongo-foo') }
+        it { is_expected.to contain_package('mongodb_mongos').with_name('mongo-foo').with_ensure('present').with_tag('mongodb_package') }
       end
 
       context 'service_manage => false' do

spec/classes/server_spec.rb

@@ -37,7 +37,7 @@
       describe 'with defaults' do
         it_behaves_like 'server classes'
 
-        it { is_expected.to contain_package('mongodb_server').with_ensure('present').with_name('mongodb-server') }
+        it { is_expected.to contain_package('mongodb_server').with_ensure('present').with_name('mongodb-server').with_tag('mongodb_package') }
 
         it do
           is_expected.to contain_file(config_file).