Skip to content

Commit 84cd577

Browse files
committed
Simplify the client class
The separate install class provided no benefit and only made it harder to follow.
1 parent fa383f6 commit 84cd577

File tree

4 files changed

+26
-47
lines changed

4 files changed

+26
-47
lines changed

manifests/client.pp

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,27 @@
22
#
33
# == Parameters
44
#
5-
# [ensure] Desired ensure state of the package. Optional.
6-
# Defaults to 'true'
5+
# $ensure:: Desired ensure state of the package. Optional. Defaults to 'true'
76
#
8-
# [package_name] Name of the package to install the client from. Default
9-
# is repository dependent.
7+
# $package_name:: Name of the package to install the client from. Default is
8+
# repository dependent.
109
#
1110
class mongodb::client (
1211
Variant[Boolean, String] $ensure = $mongodb::params::package_ensure_client,
1312
Optional[String] $package_name = $mongodb::params::client_package_name,
1413
) inherits mongodb::params {
15-
anchor { 'mongodb::client::start': }
16-
-> class { 'mongodb::client::install': }
17-
-> anchor { 'mongodb::client::end': }
14+
$package_ensure = $ensure ? {
15+
true => 'present',
16+
false => 'purged',
17+
'absent' => 'purged',
18+
default => $ensure,
19+
}
20+
21+
if $package_name {
22+
package { 'mongodb_client':
23+
ensure => $package_ensure,
24+
name => $package_name,
25+
tag => 'mongodb',
26+
}
27+
}
1828
}

manifests/client/install.pp

Lines changed: 0 additions & 28 deletions
This file was deleted.

spec/classes/client_install_spec.rb

Lines changed: 0 additions & 12 deletions
This file was deleted.

spec/classes/client_spec.rb

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,15 @@
88
context 'with defaults' do
99
it { is_expected.to compile.with_all_deps }
1010
end
11+
12+
context 'with manage_package' do
13+
let(:pre_condition) do
14+
"class { 'mongodb::globals': manage_package => true }"
15+
end
16+
17+
it { is_expected.to compile.with_all_deps }
18+
it { is_expected.to create_package('mongodb_client').with_ensure('present') }
19+
end
1120
end
1221
end
1322
end

0 commit comments

Comments
 (0)