[Rubocop] Fixes

Author: Johan De Wit

lib/puppet/provider/mongodb.rb

@@ -233,5 +233,4 @@ def self.mongo_version
   def mongo_version
     self.class.mongo_version
   end
-
 end

lib/puppet/provider/mongodb_replset/mongo.rb

@@ -144,7 +144,6 @@ def self.replset_properties
       end
       nil
     rescue Puppet::ExecutionFailure => e
-      #if e.message =~ %r{command replSetGetConfig requires authentication} || e.message =~ %r{not authorized on admin to execute command} || e.message =~ %r{no replset config has been received}
       if e.message =~ %r{command replSetGetConfig requires authentication} || e.message =~ %r{not authorized on admin to execute command}
         output = mongo_command('rs.status()', conn_string)
         if output['members']
@@ -188,9 +187,9 @@ def get_hosts_status(members)
           case e.message
           when %r{no replset config has been received}
             Puppet.warning('No replicaset config received, needs initialisation')
-          when /Authentication failed/, /not authorized on admin/, /Authentication failed/
+          when %r{Authentication failed}, %r{not authorized on admin}
             Puppet.warning "Host #{host} is available, but you are unauthorized because of authentication is enabled: #{auth_enabled}"
-          when /command replSetGetStatus requires authentication/
+          when %r{command replSetGetStatus requires authentication}
             Puppet.warning("Node #{host} is reachable but requires authentication: ReplicaSet not initialized")
           end
           alive.push(member)
@@ -410,11 +409,9 @@ def mongo_command(command, host, retries = 4)
 
   def self.mongo_command(command, host = nil, retries = 4)
     output = mongo_eval("EJSON.stringify(#{command})", 'admin', retries, host)
-    if output =~ %r{no replset config has been received} || output =~ %r{Authentication failed}
-      output = '{}'
-    end
 
     # Hack to avoid non-json empty sets
+    output = '{}' if output =~ %r{no replset config has been received} || output =~ %r{Authentication failed}
     output = '{}' if output == "null\n"
     output = '{}' if output == "\nnull\n"
 

lib/puppet/provider/mongodb_user/mongodb.rb

@@ -22,7 +22,7 @@ def self.instances
       users.map do |user|
         db = if user['db'] == '$external'
                # For external users, we need to retreive the original DB name from here.
-               user['customData']['createdBy'][/.*on db (.*)'\]$/,1]
+               user['customData']['createdBy'][%r{.*on db (.*)'\]$}, 1]
              else
                user['db']
              end
@@ -120,7 +120,7 @@ def password_hash=(_value)
     end
   end
 
-  def password=(value)
+  def password=(_value)
     command = {
       updateUser: @resource[:username],
       pwd: @resource[:password],

spec/unit/puppet/provider/mongodb_spec.rb

@@ -20,7 +20,7 @@
       'x.x.x' => { '4' => false, '5' => false, '6' => false }
     }
 
-    v.each do |key, results|
+    v.each do |key, _results|
       it "version detection for [#{key}]" do
         allow(provider_class).to receive(:mongo_eval).with('db.version()').and_return(key)
       end