Disable creating a mail relay for nginx 1.14

There's no clean way to test it, and the tests are broken in a whole lot
of ways.  With the nginx repo available for 1.28, remove the ability to
use the 1.14 package for the mailhost resource.

Fix arch package names

Author: jstraw

manifests/params.pp

@@ -111,7 +111,7 @@
         'log_user'          => 'http',
         'log_group'         => 'log',
         'package_name'      => 'nginx-mainline',
-        'mail_package_name' => 'nginx-mod-mail',
+        'mail_package_name' => 'nginx-mainline-mod-mail',
       }
     }
     'Debian': {

manifests/resource/mailhost.pp

@@ -187,6 +187,8 @@
 ) {
   if ! defined(Class['nginx']) {
     fail('You must include the nginx base class before using any defined resources')
+  } elsif versioncmp($facts.get('nginx_version', $nginx::nginx_version), '1.15.0') < 0 {
+    fail('This module does not support nginx 1.14')
   }
   if $nginx::mail_package_name {
     package { $nginx::mail_package_name:

spec/acceptance/nginx_mail_spec.rb

@@ -65,37 +65,5 @@ class { 'nginx':
     describe port(465) do
       it { is_expected.to be_listening }
     end
-
-    context 'when configured for nginx 1.14', if: !%w[Debian Archlinux].include?(fact('os.family')) do
-      shell('yum -y install nginx-1.14.1') if fact('os.family') == 'RedHat' && fact('os.release.major') == '8'
-      it 'runs successfully' do
-        pp = "
-      class { 'nginx':
-        mail            => true,
-        manage_repo     => false,
-        nginx_version   => '1.14.0',
-      }
-      nginx::resource::mailhost { 'domain1.example':
-        ensure      => present,
-        auth_http   => 'localhost/cgi-bin/auth',
-        protocol    => 'smtp',
-        listen_port => 587,
-        ssl         => true,
-        ssl_port    => 465,
-        ssl_cert    => '/etc/pki/tls/certs/blah.cert',
-        ssl_key     => '/etc/pki/tls/private/blah.key',
-        xclient     => 'off',
-      }
-        "
-
-        apply_manifest(pp, catch_failures: true)
-      end
-
-      describe file('/etc/nginx/conf.mail.d/domain1.example.conf') do
-        it 'does\'t contain `ssl` on `listen` line' do
-          is_expected.to contain 'listen                *:465;'
-        end
-      end
-    end
   end
 end

templates/mailhost/mailhost_ssl.epp

@@ -14,16 +14,13 @@
 server {
 <%= $mailhost_prepend -%>
 <%- $listen_ip.each |$ip| { -%>
-  listen                <%= $ip %>:<%= $ssl_port %><% if versioncmp($nginx_version, '1.15.0') >= 0 { %> ssl<% } %>;
+  listen                <%= $ip %>:<%= $ssl_port %> ssl;
 <%- } -%>
 <%- $ipv6_listen_ip.each |$ipv6| { -%>
   listen                [<%= $ipv6 %>]:<%= $ssl_port %> <% if $ipv6_listen_options { %><%= $ipv6_listen_options %><% } %>;
 <%- } -%>
 <%= $mailhost_common -%>
 
-<%- if versioncmp($nginx_version, '1.15.0') < 0 { -%>
-  ssl                   on;
-<% } %>
   starttls              off;
 
 <%= $mailhost_ssl_settings -%>