Ensure the mail parameter is set everywhere needed

This also ensures a failure occurs if you haven't set nginx::mail.
The nginx::mail flag was always required to actually load the resource,
it just wasn't actually setup to fail.

Author: jstraw

manifests/resource/mailhost.pp

@@ -189,7 +189,10 @@
     fail('You must include the nginx base class before using any defined resources')
   } elsif versioncmp($facts.get('nginx_version', $nginx::nginx_version), '1.15.0') < 0 {
     fail('This module does not support nginx 1.14')
+  } elsif ! $nginx::mail {
+    fail('nginx mail proxy requires the nginx::mail flag to be set true')
   }
+
   if $nginx::mail_package_name {
     package { $nginx::mail_package_name:
       ensure => 'installed',

spec/acceptance/nginx_mail_spec.rb

@@ -3,9 +3,7 @@
 require 'spec_helper_acceptance'
 
 describe 'nginx::resource::mailhost define:' do
-  has_recent_mail_module = true
-
-  has_recent_mail_module = false if fact('os.family') == 'RedHat' && fact('os.release.major') == '8'
+  has_recent_mail_module = fact('os.family') != 'RedHat' || fact('os.release.major') != '8'
 
   it 'remove leftovers from previous tests', if: fact('os.family') == 'RedHat' do
     # nginx-mod-mail is not available for all versions of nginx, the one

spec/defines/resource_mailhost_spec.rb

@@ -243,7 +243,7 @@
             end
           end
           context 'mail proxy parameters' do
-            let(:pre_condition) { ['class { "nginx": nginx_version => "1.20.0"}'] }
+            let(:pre_condition) { ['class { "nginx": nginx_version => "1.20.0", mail => true,}'] }
             let(:params) do
               {
                 listen_port: 25,
@@ -689,7 +689,7 @@
                 facts.merge(nginx_version: '1.16.0')
               end
 
-              let(:pre_condition) { ['include nginx'] }
+              let(:pre_condition) { ['class { "nginx": mail => true,}'] }
 
               it 'has `ssl` at end of listen directive' do
                 content = catalogue.resource('concat::fragment', "#{title}-ssl").send(:parameters)[:content]
@@ -698,7 +698,7 @@
             end
 
             context 'when version comes from parameter' do
-              let(:pre_condition) { ['class { "nginx": nginx_version => "1.16.0"}'] }
+              let(:pre_condition) { ['class { "nginx": nginx_version => "1.16.0", mail => true,}'] }
 
               it 'also has `ssl` at end of listen directive' do
                 content = catalogue.resource('concat::fragment', "#{title}-ssl").send(:parameters)[:content]
@@ -707,7 +707,7 @@
             end
 
             context 'mail proxy parameters' do
-              let(:pre_condition) { ['class { "nginx": nginx_version => "1.20.0"}'] }
+              let(:pre_condition) { ['class { "nginx": nginx_version => "1.20.0", mail => true,}'] }
 
               it 'configures mail proxy settings' do
                 content = catalogue.resource('concat::fragment', "#{title}-ssl").send(:parameters)[:content]