Bugfix: disable failovermethod in yumrepo on EL8

failovermethod is not supported by DNF, so remove that line completly on
EL8 (and newer) as long as $priority is unset too.

Author: sircubbi

manifests/repo/nodesource/yum.pp

@@ -16,6 +16,11 @@
     default => '0',
   }
 
+  $yum_failovermethod = (versioncmp($facts['os']['release']['major'], '8') >= 0 and $priority == 'absent') ? {
+    true    => 'absent',
+    default => 'priority',
+  }
+
   if ($ensure == 'present') {
     if $facts['os']['release']['major'] == '8' {
       file { 'dnf_module':
@@ -32,7 +37,7 @@
       descr          => $descr,
       baseurl        => $baseurl,
       enabled        => '1',
-      failovermethod => 'priority',
+      failovermethod => $yum_failovermethod,
       gpgkey         => 'file:///etc/pki/rpm-gpg/NODESOURCE-GPG-SIGNING-KEY-EL',
       gpgcheck       => '1',
       priority       => $priority,
@@ -46,7 +51,7 @@
       descr          => $source_descr,
       baseurl        => $source_baseurl,
       enabled        => $yum_source_enabled,
-      failovermethod => 'priority',
+      failovermethod => $yum_failovermethod,
       gpgkey         => 'file:///etc/pki/rpm-gpg/NODESOURCE-GPG-SIGNING-KEY-EL',
       gpgcheck       => '1',
       priority       => $priority,