Merge pull request #456 from sircubbi/bugfix_el8_repo

Disable failovermethod in yumrepo on EL8

Author: bastelfreak

.fixtures.yml

@@ -1,9 +1,9 @@
 fixtures:
   repositories:
-    "stdlib": "git://github.com/puppetlabs/puppetlabs-stdlib.git"
-    "apt": "git://github.com/puppetlabs/puppetlabs-apt.git"
-    "portage": "git://github.com/gentoo/puppet-portage.git"
-    "chocolatey": "git://github.com/puppetlabs/puppetlabs-chocolatey.git"
+    "stdlib": "https://github.com/puppetlabs/puppetlabs-stdlib.git"
+    "apt": "https://github.com/puppetlabs/puppetlabs-apt.git"
+    "portage": "https://github.com/gentoo/puppet-portage.git"
+    "chocolatey": "https://github.com/puppetlabs/puppetlabs-chocolatey.git"
     yumrepo_core:
       repo: https://github.com/puppetlabs/puppetlabs-yumrepo_core.git
       puppet_version: ">= 6.0.0"

manifests/repo/nodesource/yum.pp

@@ -16,6 +16,11 @@
     default => '0',
   }
 
+  $yum_failovermethod = (versioncmp($facts['os']['release']['major'], '8') >= 0 and $priority == 'absent') ? {
+    true    => 'absent',
+    default => 'priority',
+  }
+
   if ($ensure == 'present') {
     if $facts['os']['release']['major'] == '8' {
       file { 'dnf_module':
@@ -32,7 +37,7 @@
       descr          => $descr,
       baseurl        => $baseurl,
       enabled        => '1',
-      failovermethod => 'priority',
+      failovermethod => $yum_failovermethod,
       gpgkey         => 'file:///etc/pki/rpm-gpg/NODESOURCE-GPG-SIGNING-KEY-EL',
       gpgcheck       => '1',
       priority       => $priority,
@@ -46,7 +51,7 @@
       descr          => $source_descr,
       baseurl        => $source_baseurl,
       enabled        => $yum_source_enabled,
-      failovermethod => 'priority',
+      failovermethod => $yum_failovermethod,
       gpgkey         => 'file:///etc/pki/rpm-gpg/NODESOURCE-GPG-SIGNING-KEY-EL',
       gpgcheck       => '1',
       priority       => $priority,

spec/setup_acceptance_node.pp

@@ -0,0 +1,6 @@
+# Facter < 4 needs lsb-release for os.distro.codename
+if versioncmp($facts['facterversion'], '4.0.0') < 0 and $facts['os']['family'] == 'Debian' {
+  package { 'lsb-release':
+    ensure => 'installed',
+  }
+}