Merge pull request #231 from rtib/GH#230

Fix expression that looks like boolish logic

Author: zilchms

lib/puppet/provider/x509_cert/openssl.rb

@@ -98,7 +98,7 @@ def create
       options += ['-passin', 'env:CERTIFICATE_PASSIN']
       env['CERTIFICATE_PASSIN'] = password
     end
-    options += ['-extensions', 'v3_req'] if resource[:req_ext] != :false
+    options += ['-extensions', 'v3_req'] if resource[:req_ext]
 
     # openssl(options) doesn't work because it's impossible to pass an env
     # https://github.com/puppetlabs/puppet/issues/9493

spec/unit/puppet/provider/x509_cert/openssl_spec.rb

@@ -40,7 +40,6 @@
           '-days', 3650,
           '-key', '/tmp/foo.key',
           '-out', '/tmp/foo.crt',
-          '-extensions', 'v3_req',
         ],
         {
           combine: true,
@@ -65,7 +64,6 @@
             '-key', '/tmp/foo.key',
             '-out', '/tmp/foo.crt',
             '-passin', 'env:CERTIFICATE_PASSIN',
-            '-extensions', 'v3_req',
           ],
           {
             combine: true,
@@ -95,7 +93,6 @@
           '-CAcreateserial',
           '-CA', '/tmp/foo-ca.crt',
           '-CAkey', '/tmp/foo-ca.key',
-          '-extensions', 'v3_req',
         ],
         {
           combine: true,
@@ -126,7 +123,6 @@
           '-CA', '/tmp/foo-ca.crt',
           '-CAkey', '/tmp/foo-ca.key',
           '-passin', 'env:CERTIFICATE_PASSIN',
-          '-extensions', 'v3_req',
         ],
         {
           combine: true,