(maint) Refactor package cache refresh out of task prep action

...and into the common.sh.

Author: jpartlow

.github/actions/container_task_prep/action.yaml

@@ -17,20 +17,7 @@ runs:
         source openvox_bootstrap/files/common.sh
 
         # Ensure wget is installed.
-        if exists 'apt'; then
-          exec_and_capture apt update
-        elif exists 'apt-get'; then
-          exec_and_capture apt-get update
-        elif exists 'dnf'; then
-          exec_and_capture dnf clean all
-        elif exists 'yum'; then
-          exec_and_capture yum clean all
-        elif exists 'zypper'; then
-          exec_and_capture zypper refresh
-        else
-          echo "No package manager found."
-          exit 1
-        fi
+        refresh_package_cache
         install_package wget
 
         # Deal with missing package dependencies in the containers.

files/common.sh

@@ -350,3 +350,21 @@ install_package() {
     fail "Unable to install ${_package}. Neither dnf, yum, zypper, apt nor apt-get are installed."
   fi
 }
+
+# Update the package manager cache.
+refresh_package_cache() {
+  if exists 'apt'; then
+    exec_and_capture apt update
+  elif exists 'apt-get'; then
+    exec_and_capture apt-get update
+  elif exists 'dnf'; then
+    exec_and_capture dnf clean all
+  elif exists 'yum'; then
+    exec_and_capture yum clean all
+  elif exists 'zypper'; then
+    exec_and_capture zypper refresh
+  else
+    echo "No package manager found."
+    exit 1
+  fi
+}

tasks/install_linux.sh

@@ -61,16 +61,13 @@ set_collection_url() {
   assigned 'package_url'
 }
 
-# Installs the release package, and runs apt update if we are on a
-# Debian based platform.
+# Installs the release package, and refreshes the package manager's
+# cache.
 install_release_package() {
   local _release_package="$1"
-  local _package_type="$2"
 
   install_package_file "${_release_package}"
-  if [[ "${_package_type}" == "deb" ]]; then
-    exec_and_capture apt update
-  fi
+  refresh_package_cache
 }
 
 # Get platform information
@@ -83,6 +80,6 @@ download "${package_url}" "${local_release_package}"
 # Install the release package.
 # The release package has the repository metadata needed to install
 # packages from the collection using the platform package manager.
-install_release_package "${local_release_package}" "${package_type}"
+install_release_package "${local_release_package}"
 # Use the platform package manager to install openvox-agent
 install_package "${package}" "${version}" "${os_family}" "${os_full_version}"