(gh-20) Download with curl --fail instead of --fail-with-body

The --fail-with-body parameter was introduced into curl in
in 7.76.0 - March 31 2021 (https://curl.se/changes.html).
Older vms we are still testing on may have curls predating this version.
For example, the rocky8/alma8 vm images have curl 7.61.1 - September 5
2018.

Switching the --fail provides basically the same semantics, but without
capturing the full response body in the file. Not trying to scrape the
respone, atm, though, so this should be fine.

Author: jpartlow

.github/workflows/pr_testing_with_nested_vms.yml

@@ -0,0 +1,68 @@
+---
+name: 'PR Testing with Nested VMs'
+
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+    branches:
+      - main
+
+jobs:
+  test-install-task:
+    strategy:
+      matrix:
+        os:
+          - [almalinux, '8']
+          - [almalinux, '9']
+          - [debian, '10']
+          - [debian, '11']
+          - [debian, '12']
+          - [debian, '13', 'amd64', 'daily-latest']
+          - [rocky, '8']
+          - [rocky, '9']
+          - [ubuntu, '18.04']
+          - [ubuntu, '20.04']
+          - [ubuntu, '22.04']
+          - [ubuntu, '24.04']
+    runs-on: ubuntu-22.04
+    steps:
+      - uses: actions/checkout@v4
+      - id: install-bolt
+        uses: ./.github/actions/bolt
+        with:
+          os-codename: jammy
+      - id: vm-cluster
+        uses: jpartlow/nested_vms@v1
+        with:
+          os: ${{ matrix.os[0] }}
+          os-version: ${{ matrix.os[1] }}
+          os-arch: ${{ matrix.os[2] || 'x86_64' }}
+          image_version: ${{ matrix.os[3] }}
+          host-root-access: true
+          ruby-version: '3.3'
+          install-openvox: false
+          # Note: the cpu_mode is set to host-model for the sake of
+          # el-9 which expects at least x86_64-2 arch. This depends on
+          # the runner's architecture being sufficient, and there is
+          # probably a better way to get this set on the libvirt
+          # domain instead.
+          vms: |-
+            [
+              {
+                "role": "agent",
+                "count": 1,
+                "cpus": 2,
+                "mem_mb": 4096,
+                "cpu_mode": "host-model"
+              }
+            ]
+      - name: Run openvox_bootstrap::install task on nested vm
+        run: |-
+          bolt task run openvox_bootstrap::install --inventory kvm_automation_tooling/terraform/instances/inventory.test.yaml --targets test-agent-1
+      - name: Verify openvox-agent is installed
+        run: |-
+          bolt command run \
+            --inventory kvm_automation_tooling/terraform/instances/inventory.test.yaml --targets test-agent-1 \
+            '[[ "$(/opt/puppetlabs/bin/puppet --version)" =~ [0-9]+\.[0-9]+\.[0-9]+ ]]'

files/common.sh

@@ -143,7 +143,7 @@ download() {
   if exists 'wget'; then
     exec_and_capture wget -O "${_file}" "${_url}"
   elif exists 'curl'; then
-    exec_and_capture curl --fail-with-body -sSL -o "${_file}" "${_url}"
+    exec_and_capture curl --fail -sSL -o "${_file}" "${_url}"
   else
     fail "Unable to download ${_url}. Neither wget nor curl are installed."
   fi

spec/unit/bash/common_sh_spec.rb

@@ -247,8 +247,7 @@
         expect(status.success?).to be(false)
         expect(output).to include('Executing: curl ')
         expect(output).to include('The requested URL returned error: 404')
-        file = File.read("#{tmpdir}/file")
-        expect(file).to include('404 Not Found')
+        expect(File.exist?("#{tmpdir}/file")).to be(false)
       end
     end
   end