(maint) Remove extraneous shellcheck guards and fix some defaults

* Removes shellcheck disable SC2154 where defaults were provided for
  PT_* variables, thereby ensuring existence of a value.
* Switches to declare PT__installdir to pass shellcheck for that case.
* Removes erroneous single quotes from defaults, since they are taken
  literally in the default.

Author: jpartlow

files/common.sh

@@ -1,8 +1,7 @@
 #! /usr/bin/env bash
 
 # PT_* variables are set by Bolt.
-# shellcheck disable=SC2154
-installdir=$PT__installdir
+declare PT__installdir
 
 tempdir=$(mktemp -d)
 trap 'rm -rf $tempdir' EXIT
@@ -210,7 +209,7 @@ set_os_family() {
 #   $os_major_version
 #   $os_family
 set_platform_globals() {
-  local facts="${installdir}/facts/tasks/bash.sh"
+  local facts="${PT__installdir}/facts/tasks/bash.sh"
   if [ -e "${facts}" ]; then
     platform=$(bash "${facts}" platform)
     os_full_version=$(bash "${facts}" release)

tasks/install_build_artifact_linux.sh

@@ -3,17 +3,13 @@
 set -e
 
 # PT_* variables are set by Bolt.
-# shellcheck disable=SC2154
-installdir=$PT__installdir
-# shellcheck disable=SC2154
-version=${PT_version}
-# shellcheck disable=SC2154
-package=${PT_package:-'openvox-agent'}
-# shellcheck disable=SC2154
-artifacts_source=${PT_artifacts_source:-'https://artifacts.voxpupuli.org'}
+declare PT__installdir
+version=${PT_version:-}
+package=${PT_package:-openvox-agent}
+artifacts_source=${PT_artifacts_source:-https://artifacts.voxpupuli.org}
 
 # shellcheck source=files/common.sh
-source "${installdir}/openvox_bootstrap/files/common.sh"
+source "${PT__installdir}/openvox_bootstrap/files/common.sh"
 
 # Lookup the cpu architecture and set it as cpu_arch.
 # Translates x86_64 to amd64 and aarch64 to arm64 for debian/ubuntu.

tasks/install_linux.sh

@@ -3,21 +3,15 @@
 set -e
 
 # PT_* variables are set by Bolt.
-# shellcheck disable=SC2154
-installdir=$PT__installdir
-# shellcheck disable=SC2154
-package=${PT_package:-'openvox-agent'}
-# shellcheck disable=SC2154
-version=${PT_version:-'latest'}
-# shellcheck disable=SC2154
-collection=${PT_collection:-'openvox8'}
-# shellcheck disable=SC2154
-yum_source=${PT_yum_source:-'https://yum.voxpupuli.org'}
-# shellcheck disable=SC2154
-apt_source=${PT_apt_source:-'https://apt.voxpupuli.org'}
+declare PT__installdir
+package=${PT_package:-openvox-agent}
+version=${PT_version:-latest}
+collection=${PT_collection:-openvox8}
+yum_source=${PT_yum_source:-https://yum.voxpupuli.org}
+apt_source=${PT_apt_source:-https://apt.voxpupuli.org}
 
 # shellcheck source=files/common.sh
-source "${installdir}/openvox_bootstrap/files/common.sh"
+source "${PT__installdir}/openvox_bootstrap/files/common.sh"
 
 # Based on platform family set:
 #   repository - the package repository to download from