(maint) Install openvoxdb-termini from openvoxdb dir in artifacts

There's a peculiarity in openvoxdb-termini pathing on the artifacts
server (it's in the openvoxdb directory rather than its own
openvoxdb-termini directory) so I've special cased the pathing in
set_artifacts_package_url() for that case and am expanding the coverage
to include openvoxdb and openvoxdb-termini to expose the issue and
provide validation that these packages can also be obtained from
artifacts.

Author: jpartlow

.github/workflows/pr_testing_install_build_artifact.yaml

@@ -76,6 +76,13 @@ jobs:
   test-install-build-artifact-task-noarch:
     strategy:
       matrix:
+        package:
+          - name: openvox-server
+            version: 8.8.0
+          - name: openvoxdb
+            version: 8.9.0
+          - name: openvoxdb-termini
+            version: 8.9.0
         details:
           - image: almalinux:9
             prereqs:
@@ -124,12 +131,15 @@ jobs:
       - name: Test noarch package installation
         env:
           PT__installdir: ${{ github.workspace }}
-          PT_package: "openvox-server"
-          PT_version: "8.8.0"
+          PT_package: ${{ matrix.package.name }}
+          PT_version: ${{ matrix.package.version }}
         run: ./openvox_bootstrap/tasks/install_build_artifact_linux.sh
       - name: Verify openvox-server is installed
         shell: bash
+        env:
+          PACKAGE: ${{ matrix.package.name }}
+          VERSION: ${{ matrix.package.version }}
         run: |-
-          /opt/puppetlabs/bin/puppet resource package openvox-server > openvox-server.status
-          cat openvox-server.status
-          grep "ensure.*=>.*'8.8.0" openvox-server.status
+          /opt/puppetlabs/bin/puppet resource package "${PACKAGE}" > openvox-package.status
+          cat openvox-package.status
+          grep "ensure.*=>.*'${VERSION}" openvox-package.status

files/common.sh

@@ -493,7 +493,17 @@ set_artifacts_package_url() {
       fail "Unhandled package type: '${package_type}'"
       ;;
   esac
-  package_url="${_artifacts_source}/${_package}/${_version}/${package_name}"
+
+  case "${_package}" in
+    openvoxdb-termini)
+      local _package_dir='openvoxdb'
+      ;;
+    *)
+      local _package_dir="${_package}"
+      ;;
+  esac
+
+  package_url="${_artifacts_source}/${_package_dir}/${_version}/${package_name}"
 
   export package_name # quiets shellcheck SC2034
   assigned 'package_name'

spec/unit/bash/common_sh_spec.rb

@@ -544,7 +544,7 @@
         expect(status.success?).to be(true)
         package_name = 'openvoxdb-termini-8.9.1-1.el.noarch.rpm'
         expect(output).to include("Assigned package_name=#{package_name}")
-        expect(output).to include("Assigned package_url=https://foo/openvoxdb-termini/8.9.1/#{package_name}")
+        expect(output).to include("Assigned package_url=https://foo/openvoxdb/8.9.1/#{package_name}")
       end
 
       it 'builds a fedora url' do
@@ -558,5 +558,23 @@
         expect(output).to include("Assigned package_url=https://foo/openvox-agent/8.18.0/#{package_name}")
       end
     end
+
+    context 'pathing' do
+      it 'looks for openvoxdb in the openvoxdb dir' do
+        allow_script.to set_env('os_family', 'el')
+        output, status = test('set_artifacts_package_url https://foo openvoxdb 8.9.1')
+
+        expect(status.success?).to be(true)
+        expect(output).to match(%r{Assigned package_url=https://foo/openvoxdb/8\.9\.1/})
+      end
+
+      it 'lookds for openvoxdb-termini in the openvoxdb dir as well' do
+        allow_script.to set_env('os_family', 'el')
+        output, status = test('set_artifacts_package_url https://foo openvoxdb-termini 8.9.1')
+
+        expect(status.success?).to be(true)
+        expect(output).to match(%r{Assigned package_url=https://foo/openvoxdb/8\.9\.1/})
+      end
+    end
   end
 end