Remove "We do not try to mimic a version scheme validation" version scheme validation.

[arjenz]

Hi,

In a way this is a followup to #727. We have internal repo where the pip package versions are tagged for instance as release/1.2.3 or testing/2.3.4, which is "not a version" according to the "this does not mimic version scheme validation" version scheme validator at https://github.com/voxpupuli/puppet-python/blob/master/manifests/pip.pp#L163. On module version 6.x this still works, but not on 7.x or 8.x.

#727 adds the v prefix, so instead of updating the validator with arbitrary strings whenever someone needs it, I would maybe propose to let the 3rd line of the comment carry the weight of deciding what a valid package version is:

# We do not try to mimic a version scheme validation which is already implemented by the package manager.
# If it starts with a number it is probably a version.
# If it wasn't or if there is any error, the package manager will trigger a failure.

and not try to be smarter than the pip package handler. Any ideas/feedback? I would happily work on PR if we can agree on removing the validator or make it a bit more flexible (like allowing whatever/ before "versionish" like it's defined now, to allow some kind of namespace prefix.

[kenyon]

Removing the version validation sounds good to me. Why close this issue?

[arjenz]

@kenyon I was experimenting a bit more, and turns out that the pip provider doesn't like any arbitrary string for a git+ package, and then it would skip over the package silently, so I'm investigating a bit more on what's going on before I suggest anything :)