Merge pull request #962 from bugfood/missing-command

add a workaround for running with --noop or --tags

Author: wyardley

lib/puppet/provider/rabbitmq_cli.rb

@@ -54,6 +54,14 @@ def self.rabbitmqctl_list(resource, *opts)
         ['-q']
       end
     rabbitmqctl("list_#{resource}", *list_opts, *opts)
+  rescue Puppet::MissingCommand
+    # rabbitmqctl is not present. Normally we would have installed a package
+    # that provides rabbitmqctl by now, but if we're running under --noop or
+    # with a restrictive set of tags, the package may not have been installed.
+    # Return an empty string to avoid error. This may give false positives for
+    # resources under --noop!
+    Puppet.debug('rabbitmqctl command not found; assuming rabbitmq is not installed')
+    ''
   end
 
   def self.rabbitmq_running

lib/puppet/provider/rabbitmq_plugin/rabbitmqplugins.rb

@@ -18,6 +18,11 @@ def self.plugin_list
       # To preserve idempotency we should get all enabled plugins regardless of implicitly or
       # explicitly enabled.
       rabbitmqplugins('list', '-e', '-m')
+    rescue Puppet::MissingCommand
+      # See note about Puppet::MissingCommand in:
+      # lib/puppet/provider/rabbitmq_cli.rb
+      Puppet.debug('rabbitmqplugins command not found; assuming rabbitmq is not installed')
+      ''
     end
     # Split by newline.
     lines = list_str.split(%r{\n})