Merge pull request #851 from jplindquist/check_password

wyardley · web-flow · commit 3e46d04a8da1 · 2020-07-13T17:01:38.000-07:00
Escape double quotes in password during comparison
diff --git a/lib/puppet/provider/rabbitmq_user/rabbitmqctl.rb b/lib/puppet/provider/rabbitmq_user/rabbitmqctl.rb
@@ -69,7 +69,7 @@ def check_password(password)
     check_access_control = [
       'rabbit_access_control:check_user_pass_login(',
       %[list_to_binary("#{@resource[:name]}"), ],
-      %[list_to_binary("#{password}")).]
+      %[list_to_binary("#{password.to_s.gsub('"', '\\"')}")).]
     ]
 
     response = rabbitmqctl('eval', check_access_control.join)

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ def check_password(password)`
`69`	`69`	`check_access_control = [`
`70`	`70`	`'rabbit_access_control:check_user_pass_login(',`
`71`	`71`	`%[list_to_binary("#{@resource[:name]}"), ],`
`72`		`- %[list_to_binary("#{password}")).]`
	`72`	`+ %[list_to_binary("#{password.to_s.gsub('"', '\\"')}")).]`
`73`	`73`	`]`
`74`	`74`
`75`	`75`	`response = rabbitmqctl('eval', check_access_control.join)`