trying to fix rspec-puppet

Author: bastelfreak

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2023-08-17 21:37:37 UTC using RuboCop version 1.50.2.
+# on 2024-05-18 22:27:55 UTC using RuboCop version 1.50.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -20,3 +20,13 @@ RSpec/BeEq:
 RSpec/PendingWithoutReason:
   Exclude:
     - 'spec/acceptance/class_spec.rb'
+
+# Offense count: 4
+RSpec/RepeatedExampleGroupBody:
+  Exclude:
+    - 'spec/classes/rabbitmq_spec.rb'
+
+# Offense count: 14
+RSpec/RepeatedExampleGroupDescription:
+  Exclude:
+    - 'spec/classes/rabbitmq_spec.rb'

lib/puppet/type/rabbitmq_parameter.rb

@@ -85,7 +85,7 @@
     [self[:name].split('@')[1]]
   end
 
-  def set_parameters(hash) # rubocop:disable Style/AccessorMethodName
+  def set_parameters(hash) # rubocop:disable Naming/AccessorMethodName
     # Hack to ensure :autoconvert is initialized before :value
     self[:autoconvert] = hash[:autoconvert] if hash.key?(:autoconvert)
     super

spec/classes/rabbitmq_spec.rb

@@ -1,8 +1,5 @@
 # frozen_string_literal: true
 
-# rubocop:disable RSpec/RepeatedExampleGroupDescription
-# rubocop:disable RSpec/RepeatedExampleGroupBody
-
 require 'spec_helper'
 
 describe 'rabbitmq' do
@@ -144,13 +141,13 @@
             it { is_expected.not_to contain_file('/etc/default/rabbitmq-server') }
           end
 
-          if os_facts[:systemd]
+          if os_facts['systemd']
             selinux_ignore_defaults = os_facts[:os]['family'] == 'RedHat'
 
             it do
               is_expected.to contain_systemd__service_limits("#{name}.service").
                 with_selinux_ignore_defaults(selinux_ignore_defaults).
-                with_limits('LimitNOFILE' => value).
+                with_limits({ 'LimitNOFILE' => value, 'OOMScoreAdjust' => 0 }).
                 with_restart_service(false)
             end
           else
@@ -179,10 +176,10 @@
             it { is_expected.not_to contain_file('/etc/default/rabbitmq-server') }
           end
 
-          if os_facts[:systemd]
+          if os_facts['systemd']
             it do
               is_expected.to contain_systemd__service_limits("#{name}.service").
-                with_limits('OOMScoreAdjust' => value).
+                with_limits({ 'LimitNOFILE' => 16_384, 'OOMScoreAdjust' => value }).
                 with_restart_service(false)
             end
           else
@@ -201,14 +198,14 @@
         end
       end
 
-      context 'on systems with systemd', if: os_facts[:systemd] do
+      context 'on systems with systemd', if: os_facts['systemd'] do
         it do
           is_expected.to contain_systemd__service_limits("#{name}.service").
             with_restart_service(false)
         end
       end
 
-      context 'on systems without systemd', unless: os_facts[:systemd] do
+      context 'on systems without systemd', unless: os_facts['systemd'] do
         it { is_expected.not_to contain_systemd__service_limits("#{name}.service") }
       end
 
@@ -1806,6 +1803,3 @@
     end
   end
 end
-
-# rubocop:enable RSpec/RepeatedExampleGroupDescription
-# rubocop:enable RSpec/RepeatedExampleGroupBody