rubocop: autofix

Author: bastelfreak

.rubocop.yml

@@ -1,4 +1,6 @@
 ---
+inherit_from: .rubocop_todo.yml
+
 # Managed by modulesync - DO NOT EDIT
 # https://voxpupuli.org/docs/updating-files-managed-with-modulesync/
 

.rubocop_todo.yml

@@ -0,0 +1,22 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2023-08-17 21:37:37 UTC using RuboCop version 1.50.2.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 8
+# This cop supports unsafe autocorrection (--autocorrect-all).
+RSpec/BeEq:
+  Exclude:
+    - 'spec/unit/puppet/provider/rabbitmq_plugin/rabbitmqctl_spec.rb'
+    - 'spec/unit/puppet/provider/rabbitmq_policy/rabbitmqctl_spec.rb'
+    - 'spec/unit/puppet/provider/rabbitmq_user_permissions/rabbitmqctl_spec.rb'
+    - 'spec/unit/puppet/provider/rabbitmq_vhost/rabbitmqctl_spec.rb'
+    - 'spec/unit/puppet/type/rabbitmq_user_permissions_spec.rb'
+
+# Offense count: 3
+RSpec/PendingWithoutReason:
+  Exclude:
+    - 'spec/acceptance/class_spec.rb'

lib/facter/rabbitmq_nodename.rb

@@ -5,7 +5,7 @@
     if Facter::Util::Resolution.which('rabbitmqctl')
       rabbitmq_nodename = Facter::Core::Execution.execute('rabbitmqctl status 2>&1')
       begin
-        %r{^Status of node '?([\w.\-]+@[\w.\-]+)'?}.match(rabbitmq_nodename)[1]
+        %r{^Status of node '?([\w.-]+@[\w.-]+)'?}.match(rabbitmq_nodename)[1]
       rescue StandardError
         Facter.debug("Error: rabbitmq_nodename facter failed. Output was #{rabbitmq_nodename}")
       end

spec/classes/rabbitmq_spec.rb

@@ -372,7 +372,7 @@
       describe 'does not contain pre-ranch settings with default config' do
         it do
           is_expected.to contain_file('rabbitmq.config'). \
-            without_content(%r{binary,}).                 \
+            without_content(%r{binary,}). \
             without_content(%r{\{packet,        raw\},}). \
             without_content(%r{\{reuseaddr,     true\},})
         end
@@ -383,7 +383,7 @@
 
         it do
           is_expected.to contain_file('rabbitmq.config'). \
-            with_content(%r{binary,}).                 \
+            with_content(%r{binary,}). \
             with_content(%r{\{packet,        raw\},}). \
             with_content(%r{\{reuseaddr,     true\},})
         end

spec/unit/facter/util/fact_rabbitmq_plugins_dirs_spec.rb

@@ -10,24 +10,15 @@
       it do
         Facter::Util::Resolution.expects(:which).with('rabbitmqctl').returns(true)
         Facter::Core::Execution.expects(:execute).with("rabbitmqctl eval 'application:get_env(rabbit, plugins_dir).'").returns('{ok,"/usr/lib/rabbitmq/plugins:/usr/lib/rabbitmq/lib/rabbitmq_server-3.7.10/plugins"}')
-        expect(Facter.fact(:rabbitmq_plugins_dirs).value).to match_array(
-          [
-            '/usr/lib/rabbitmq/plugins',
-            '/usr/lib/rabbitmq/lib/rabbitmq_server-3.7.10/plugins'
-          ]
-        )
+        expect(Facter.fact(:rabbitmq_plugins_dirs).value).to contain_exactly('/usr/lib/rabbitmq/plugins', '/usr/lib/rabbitmq/lib/rabbitmq_server-3.7.10/plugins')
       end
     end
 
     context 'with only 1 plugins dir' do
       it do
         Facter::Util::Resolution.expects(:which).with('rabbitmqctl').returns(true)
         Facter::Core::Execution.expects(:execute).with("rabbitmqctl eval 'application:get_env(rabbit, plugins_dir).'").returns('{ok,"/usr/lib/rabbitmq/lib/rabbitmq_server-0.0.0/plugins"}')
-        expect(Facter.fact(:rabbitmq_plugins_dirs).value).to match_array(
-          [
-            '/usr/lib/rabbitmq/lib/rabbitmq_server-0.0.0/plugins'
-          ]
-        )
+        expect(Facter.fact(:rabbitmq_plugins_dirs).value).to contain_exactly('/usr/lib/rabbitmq/lib/rabbitmq_server-0.0.0/plugins')
       end
     end
 

spec/unit/puppet/provider/rabbitmq_user_permissions/rabbitmqctl_spec.rb

@@ -37,8 +37,7 @@
   end
 
   it 'does not match an empty list' do
-    provider.class.expects(:rabbitmqctl_list).with('user_permissions', 'foo').returns <<-EOT
-    EOT
+    provider.class.expects(:rabbitmqctl_list).with('user_permissions', 'foo').returns ''
     expect(provider.exists?).to eq(nil)
   end
 

spec/unit/puppet/type/rabbitmq_parameter_spec.rb

@@ -96,7 +96,7 @@
 
     it 'does not convert numeric string to integer' do
       expect(parameter[:value]['myparameter']).to eq('1800000')
-      expect(parameter[:value]['myparameter']).to be_kind_of(String)
+      expect(parameter[:value]['myparameter']).to be_a(String)
     end
   end
 end