[style] additional rubocop fixes and ignores

- Additional manual style updates for rubocop warnings
- Ignore warnings about duplicates in the class spec
- Ignore remaining items (facter for erlang SSL path doesn't work with frozen
  strings set

Co-authored-by: Christos Papageorgiou <[email protected]>

Author: wyardley

.github/CONTRIBUTING.md

@@ -124,7 +124,7 @@ If you have Ruby 2.x or want a specific version of Puppet,
 you must set an environment variable such as:
 
 ```sh
-export PUPPET_GEM_VERSION="~> 5.5.6"
+export PUPPET_GEM_VERSION="~> 6.1.0"
 ```
 
 You can install all needed gems for spec tests into the modules directory by

Gemfile

@@ -1,7 +1,7 @@
 # Managed by modulesync - DO NOT EDIT
 # https://voxpupuli.org/docs/updating-files-managed-with-modulesync/
 
-source ENV['GEM_SOURCE'] || "https://rubygems.org"
+source ENV['GEM_SOURCE'] || 'https://rubygems.org'
 
 group :test do
   gem 'voxpupuli-test', '~> 5.0',   :require => false

lib/facter/erl_ssl_path.rb

@@ -1,9 +1,10 @@
-# frozen_string_literal: true
+# rubocop:disable Style/FrozenStringLiteralComment
 
 # Fact to get the ssl path for the erlang distribution in the current
 # system as described in the RabbitMQ docs [1].
 #
 # [1] https://www.rabbitmq.com/clustering-ssl.html
+
 Facter.add(:erl_ssl_path) do
   setcode do
     if Facter::Util::Resolution.which('erl')
@@ -13,3 +14,4 @@
     end
   end
 end
+# rubocop:enable Style/FrozenStringLiteralComment

lib/puppet/type/rabbitmq_binding.rb

@@ -115,7 +115,7 @@ def self.title_patterns
 
   newproperty(:arguments) do
     desc 'binding arguments'
-    defaultto {}
+    defaultto({})
     validate do |value|
       resource.validate_argument(value)
     end

lib/puppet/type/rabbitmq_erlang_cookie.rb

@@ -23,11 +23,9 @@ def change_to_s(_current, _desired)
       'The rabbitmq erlang cookie was changed'
     end
 
-    # rubocop:disable Style/PredicateName
     def is_to_s(_value)
       '[old content redacted]'
     end
-    # rubocop:enable Style/PredicateName
 
     def should_to_s(_value)
       '[new content redacted]'

lib/puppet/type/rabbitmq_exchange.rb

@@ -59,7 +59,7 @@
 
   newparam(:arguments) do
     desc 'Exchange arguments example: {"hash-header": "message-distribution-hash"}'
-    defaultto {}
+    defaultto({})
   end
 
   newparam(:user) do

lib/puppet/type/rabbitmq_queue.rb

@@ -47,7 +47,7 @@
 
   newparam(:arguments) do
     desc 'Queue arguments example: {x-message-ttl => 60, x-expires => 10}'
-    defaultto {}
+    defaultto({})
     validate do |value|
       resource.validate_argument(value)
     end

lib/puppet/type/rabbitmq_user.rb

@@ -49,11 +49,9 @@ def change_to_s(_current, _desired)
       'password has been changed'
     end
 
-    # rubocop:disable Style/PredicateName
     def is_to_s(_value)
       '[old password redacted]'
     end
-    # rubocop:enable Style/PredicateName
 
     def should_to_s(_value)
       '[new password redacted]'

spec/acceptance/class_spec.rb

@@ -4,13 +4,7 @@
 
 describe 'rabbitmq class:' do
   case fact('os.family')
-  when 'RedHat'
-    package_name = 'rabbitmq-server'
-    service_name = 'rabbitmq-server'
-  when 'SUSE'
-    package_name = 'rabbitmq-server'
-    service_name = 'rabbitmq-server'
-  when 'Debian'
+  when 'RedHat', 'SUSE', 'Debian'
     package_name = 'rabbitmq-server'
     service_name = 'rabbitmq-server'
   when 'Archlinux'
@@ -124,7 +118,7 @@ class { 'rabbitmq':
       it { is_expected.to be_running }
     end
 
-    describe port(5672) do
+    describe port(5672), :port5672 do
       it { is_expected.to be_listening.on('0.0.0.0').with('tcp') }
     end
 
@@ -157,13 +151,14 @@ class { 'rabbitmq':
       it { is_expected.to be_running }
     end
 
-    describe port(5672) do
+    describe port(5672), :port5671 do
       it { is_expected.to be_listening.on('127.0.0.1').with('tcp') }
     end
 
     describe port(15_672) do
       it { is_expected.to be_listening.on('127.0.0.1').with('tcp') }
     end
+
     # This listens on all interfaces regardless of these settings
 
     describe port(25_672) do
@@ -195,7 +190,7 @@ class { 'rabbitmq':
       it { is_expected.to be_running }
     end
 
-    describe port(5671) do
+    describe port(5671), :port5671 do
       it { is_expected.to be_listening.on('0.0.0.0').with('tcp') }
     end
 
@@ -223,7 +218,7 @@ class { 'rabbitmq':
       it { is_expected.to be_running }
     end
 
-    describe port(5672) do
+    describe port(5672), :port5672 do
       it { is_expected.to be_listening.on('0.0.0.0').with('tcp') }
     end
 

spec/classes/rabbitmq_spec.rb

@@ -1,5 +1,8 @@
 # frozen_string_literal: true
 
+# rubocop:disable RSpec/RepeatedExampleGroupDescription
+# rubocop:disable RSpec/RepeatedExampleGroupBody
+
 require 'spec_helper'
 
 describe 'rabbitmq' do
@@ -1788,3 +1791,6 @@
     end
   end
 end
+
+# rubocop:enable RSpec/RepeatedExampleGroupDescription
+# rubocop:enable RSpec/RepeatedExampleGroupBody