List both implicitly and explicitly enabled plugins so that rabbitmq_plugin is idempotent irregardless of install ordering

Author: nmaludy

lib/puppet/provider/rabbitmq_plugin/rabbitmqplugins.rb

@@ -6,7 +6,15 @@
 
   def self.instances
     plugin_list = run_with_retries do
-      rabbitmqplugins('list', '-E', '-m')
+      # Pass in -E for explicitly enabled plugins as well as -e for implicitly enabled plugins
+      # Implicitly enabled plugins are those that were enabled as a dependency of another plugin/
+      # If we do not pass in -e then the order if plugin installation matters within the puppet
+      # code. Example, if Plugin A depends on Plugin B and we install Plugin B first it will
+      # implicitly enable Plugin A. Then when we go to run Puppet a second time without the
+      # -e parameter, we won't see Plugin A as being enabled so we'll try to install it again.
+      # To preserve idempotency we should get all enabled plugins regardless of implicitly or
+      # explicitly enabled.
+      rabbitmqplugins('list', '-E', '-e', '-m')
     end
 
     plugin_list.split(%r{\n}).map do |line|
@@ -32,6 +40,6 @@ def destroy
   end
 
   def exists?
-    run_with_retries { rabbitmqplugins('list', '-E', '-m') }.split(%r{\n}).include? resource[:name]
+    run_with_retries { rabbitmqplugins('list', '-E', '-e', '-m') }.split(%r{\n}).include? resource[:name]
   end
 end

spec/unit/puppet/provider/rabbitmq_plugin/rabbitmqctl_spec.rb

@@ -10,7 +10,7 @@
   let(:provider) { provider_class.new(resource) }
 
   it 'matches plugins' do
-    provider.expects(:rabbitmqplugins).with('list', '-E', '-m').returns("foo\n")
+    provider.expects(:rabbitmqplugins).with('list', '-E', '-e', '-m').returns("foo\n")
     expect(provider.exists?).to eq(true)
   end