Merge pull request #219 from voxpupuli/modulesync

fix exec idempotency issues

Author: bastelfreak

.devcontainer/devcontainer.json

@@ -0,0 +1,4 @@
+{
+	"name": "VoxBox",
+	"image": "ghcr.io/voxpupuli/voxbox:latest"
+}

.github/CONTRIBUTING.md

@@ -22,4 +22,4 @@ permissions:
 jobs:
   puppet:
     name: Puppet
-    uses: voxpupuli/gha-puppet/.github/workflows/beaker.yml@v3
+    uses: voxpupuli/gha-puppet/.github/workflows/beaker.yml@v4

.github/workflows/ci.yml

@@ -0,0 +1,22 @@
+---
+# Managed by modulesync - DO NOT EDIT
+# https://voxpupuli.org/docs/updating-files-managed-with-modulesync/
+
+name: Create Git tag
+
+on:
+  workflow_dispatch:
+
+permissions: {}
+
+jobs:
+  create_tag:
+    uses: 'voxpupuli/gha-puppet/.github/workflows/create_tag.yml@v4'
+    with:
+      allowed_owner: 'voxpupuli'
+      git_name: 'pccibot'
+      git_email: '12855858+pccibot@users.noreply.github.com'
+    secrets:
+      # Configure secrets here:
+      #  https://docs.github.com/en/actions/security-guides/encrypted-secrets
+      ssh_private_key: ${{ secrets.PCCI_SSH_PRIVATE_KEY }}

.github/workflows/create_tag.yml

@@ -17,11 +17,14 @@ permissions:
 
 jobs:
   release_prep:
-    uses: 'voxpupuli/gha-puppet/.github/workflows/prepare_release.yml@v3'
+    uses: 'voxpupuli/gha-puppet/.github/workflows/prepare_release.yml@v4'
     with:
       version: ${{ github.event.inputs.version }}
       allowed_owner: 'voxpupuli'
+      git_name: 'pccibot'
+      git_email: '12855858+pccibot@users.noreply.github.com'
     secrets:
       # Configure secrets here:
       #  https://docs.github.com/en/actions/security-guides/encrypted-secrets
       github_pat: '${{ secrets.PCCI_PAT_RELEASE_PREP }}'
+      ssh_private_key: '${{ secrets.PCCI_SSH_PRIVATE_KEY }}'

.github/workflows/prepare_release.yml

@@ -8,15 +8,17 @@ name: Release
 on:
   push:
     tags:
-      - '*'
+      # https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#onpushbranchestagsbranches-ignoretags-ignore
+      # https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#filter-pattern-cheat-sheet
+      - 'v[0-9]+.[0-9]+.[0-9]+'
 
 permissions:
   contents: write
 
 jobs:
   release:
     name: Release
-    uses: voxpupuli/gha-puppet/.github/workflows/release.yml@v3
+    uses: voxpupuli/gha-puppet/.github/workflows/release.yml@v4
     with:
       allowed_owner: 'voxpupuli'
     secrets:

.github/workflows/release.yml

@@ -2,4 +2,4 @@
 # Managed by modulesync - DO NOT EDIT
 # https://voxpupuli.org/docs/updating-files-managed-with-modulesync/
 
-modulesync_config_version: '10.1.0'
+modulesync_config_version: '10.7.0'

.msync.yml

@@ -4,8 +4,8 @@
 source ENV['GEM_SOURCE'] || 'https://rubygems.org'
 
 group :test do
-  gem 'voxpupuli-test', '~> 11.0',  :require => false
-  gem 'puppet_metadata', '~> 5.0',  :require => false
+  gem 'voxpupuli-test', '~> 14.0',  :require => false
+  gem 'puppet_metadata', '~> 6.0',  :require => false
 end
 
 group :development do
@@ -18,7 +18,7 @@ group :system_tests do
 end
 
 group :release do
-  gem 'voxpupuli-release', '~> 4.0',  :require => false
+  gem 'voxpupuli-release', '~> 5.3',  :require => false
 end
 
 gem 'rake', :require => false

Gemfile

@@ -35,7 +35,7 @@ def gemlist(hash)
                end
 
     if (name = hash[:justme])
-      command << ("^#{name}$")
+      command << "^#{name}$"
     end
 
     # use proxy if proxy_url is set
@@ -69,7 +69,7 @@ def self.gemsplit(desc)
       version = Regexp.last_match(2).split(%r{,\s*})
       {
         name: name,
-        ensure: version
+        ensure: version,
       }
     else
       Puppet.warning "Could not match #{desc}"

lib/puppet/provider/rvm_gem/gem.rb

@@ -39,7 +39,7 @@
         1, 'read', 'read-only',
         2, 'fail', 'read-fail',
         3, 'packages', 'install-packages',
-        4, 'enable', 'enabled'
+        4, 'enable', 'enabled',
       ]
 
       raise("Invalid autolib mode: #{value}") unless modes.include? value