forked from blt04/puppet-rvm
-
Notifications
You must be signed in to change notification settings - Fork 102
curl | bash is bad... because: #127
Copy link
Copy link
Open
Description
The command:
command => "curl -fsSL https://get.rvm.io | bash -s -- --version ${actual_version}",
Will not detect a failure in "curl" ... recently there was an issue with the get.rvm.io SSL certificate, and the rvm-system continued on its merry way because "bash" received an "empty file." Anything that uses RVM beyond that will fail because "rvm" doesn't exist. I would recommend separating the curl command from the bash command, or at least prefixing the command with set -o pipefail;.
~tommy
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels