Merge pull request #376 from voxpupuli/fail-socket

only accept socket_entry for socket units

Author: ekohl

manifests/manage_dropin.pp

@@ -86,6 +86,10 @@
     fail("Systemd::Manage_dropin[${name}]: for unit ${unit} path_entry is only valid for path units")
   }
 
+  if $socket_entry and $unit !~ Pattern['^[^/]+\.socket'] {
+    fail("Systemd::Manage_dropin[${name}]: for unit ${unit} socket_entry is only valid for socket units")
+  }
+
   systemd::dropin_file { $name:
     ensure                  => $ensure,
     filename                => $filename,

manifests/manage_unit.pp

@@ -124,6 +124,10 @@
     fail("Systemd::Manage_unit[${name}]: path_entry is only valid for path units")
   }
 
+  if $socket_entry and $name !~ Pattern['^[^/]+\.socket'] {
+    fail("Systemd::Manage_unit[${name}]: socket_entry is only valid for socket units")
+  }
+
   if $ensure != 'absent' and  $name =~ Pattern['^[^/]+\.service'] and !$service_entry {
     fail("Systemd::Manage_unit[${name}]: service_entry is required for service units")
   }

spec/defines/manage_unit_spec.rb

@@ -75,6 +75,14 @@
 
             it { is_expected.to compile.and_raise_error(%r{path_entry is only valid for path units}) }
           end
+
+          context 'with a socket entry' do
+            let(:params) do
+              super().merge(socket_entry: { 'ListenStream' => '1337' })
+            end
+
+            it { is_expected.to compile.and_raise_error(%r{socket_entry is only valid for socket units}) }
+          end
         end
 
         context 'on a timer' do