fix: use provided database port in pgpass

refactor: more readable code

Author: teluq-pbrideau

manifests/database/postgresql.pp

@@ -68,10 +68,12 @@
     }
   }
 
+  $db_port = pick($database_port, '5432')
+
   exec { 'update_pgpass':
-    command => "echo ${database_host}:5432:${database_name}:${database_user}:${database_password} >> /root/.pgpass",
+    command => "echo ${database_host}:${db_port}:${database_name}:${database_user}:${database_password} >> /root/.pgpass",
     path    => "/bin:/usr/bin:/usr/local/sbin:/usr/local/bin:${database_path}",
-    unless  => "grep \"${database_host}:5432:${database_name}:${database_user}:${database_password}\" /root/.pgpass",
+    unless  => "grep \"${database_host}:${db_port}:${database_name}:${database_user}:${database_password}\" /root/.pgpass",
     require => File['/root/.pgpass'],
   }