Move node setup from prepare_host to setup_acceptance_node.pp

This is setup code only needs to happen once. By using
setup_acceptance_node.pp we can rely on editors to use proper syntax
highlighting and use lint to validate our style.

Author: ekohl

spec/setup_acceptance_node.pp

@@ -0,0 +1,33 @@
+case $facts['os']['name'] {
+  'Debian': {
+    # On Debian it seems that make is searching for mkdir in /usr/bin/ but mkdir
+    # does not exist. Symlink it from /bin/mkdir to make it work.
+    file { '/usr/bin/mkdir':
+      ensure => link,
+      target => '/bin/mkdir',
+    }
+  }
+  'Ubuntu': {
+    # The Ubuntu 18.04+ docker image has a dpkg config that won't install docs, to keep used space low
+    # zabbix packages their SQL file as doc, we need that for bootstrapping the database
+    file { '/etc/dpkg/dpkg.cfg.d/excludes':
+      ensure => absent,
+    }
+  }
+  default: {}
+}
+
+case $facts['os']['family'] {
+  'RedHat': {
+    if $facts['os']['release']['major'] == '7' {
+      # The CentOS docker image has a yum config that won't install docs, to keep used space low
+      # zabbix packages their SQL file as doc, we need that for bootstrapping the database
+      augeas { 'remove tsflags=nodocs from yum.conf':
+        changes => [
+          'rm /files/etc/yum.conf/main/tsflags',
+        ],
+      }
+    }
+  }
+  default: {}
+}

spec/support/acceptance/prepare_host.rb

@@ -3,19 +3,8 @@
 def prepare_host
   if fact('os.family') == 'RedHat'
     shell('rm -rf /etc/yum.repos.d/Zabbix*.repo; rm -rf /var/cache/yum/x86_64/*/Zabbix*; yum clean all --verbose')
-    # The CentOS docker image has a yum config that won't install docs, to keep used space low
-    # zabbix packages their SQL file as doc, we need that for bootstrapping the database
-    shell('sed -i "/nodocs/d" /etc/yum.conf') if fact('os.release.major').to_i == 7
   end
 
-  # The Ubuntu 18.04+ docker image has a dpkg config that won't install docs, to keep used space low
-  # zabbix packages their SQL file as doc, we need that for bootstrapping the database
-  shell('rm -f /etc/dpkg/dpkg.cfg.d/excludes') if fact('os.distro.id') == 'Ubuntu'
-
-  # On Debian it seems that make is searching for mkdir in /usr/bin/ but mkdir
-  # does not exist. Symlink it from /bin/mkdir to make it work.
-  shell('ln -sf /bin/mkdir /usr/bin/mkdir') if fact('os.distro.id') == 'Debian'
-
   cleanup_puppet = <<-SHELL
       $services = $facts['os']['family'] ? {
         'RedHat' => ['zabbix-server', 'httpd'],