Skip to content

Commit b98839e

Browse files
committed
Update unit test specs to handle firewall rules with multiple server support
1 parent e1aba9e commit b98839e

File tree

1 file changed

+30
-4
lines changed

1 file changed

+30
-4
lines changed

spec/classes/agent_spec.rb

Lines changed: 30 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -167,24 +167,50 @@
167167
it { is_expected.to contain_file(config_path).with_content %r{^HostInterface=testinterface$} }
168168
end
169169

170-
context 'when declaring manage_firewall is true' do
170+
context 'when declaring manage_firewall is true with single server' do
171171
let :params do
172172
{
173+
server: '192.168.1.1',
173174
manage_firewall: true
174175
}
175176
end
176177

177-
it { is_expected.to contain_firewall('150 zabbix-agent') }
178+
it { is_expected.to contain_firewall('150 zabbix-agent from 192.168.1.1') }
178179
end
179180

180-
context 'when declaring manage_firewall is false' do
181+
context 'when declaring manage_firewall is false with single server' do
181182
let :params do
182183
{
184+
server: '192.168.1.1',
183185
manage_firewall: false
184186
}
185187
end
186188

187-
it { is_expected.not_to contain_firewall('150 zabbix-agent') }
189+
it { is_expected.not_to contain_firewall('150 zabbix-agent from 192.168.1.1') }
190+
end
191+
192+
context 'when declaring manage_firewall is true with multiple servers' do
193+
let :params do
194+
{
195+
server: '192.168.1.1,10.11.12.13',
196+
manage_firewall: true
197+
}
198+
end
199+
200+
it { is_expected.to contain_firewall('150 zabbix-agent from 192.168.1.1') }
201+
it { is_expected.to contain_firewall('150 zabbix-agent from 10.11.12.13') }
202+
end
203+
204+
context 'when declaring manage_firewall is false with multiple servers' do
205+
let :params do
206+
{
207+
server: '192.168.1.1,10.11.12.13',
208+
manage_firewall: false
209+
}
210+
end
211+
212+
it { is_expected.not_to contain_firewall('150 zabbix-agent from 192.168.1.1') }
213+
it { is_expected.not_to contain_firewall('150 zabbix-agent from 10.11.12.13') }
188214
end
189215

190216
context 'it creates a startup script' do

0 commit comments

Comments
 (0)