Improve zabbix_proxy acceptance tests

Author: baurmatt

spec/acceptance/zabbix_proxy_spec.rb

@@ -3,48 +3,58 @@
 
 describe 'zabbix_proxy type' do
   context 'create zabbix_proxy resources' do
-    it 'runs successfully' do
-      # This will deploy a running Zabbix setup (server, web, db) which we can
-      # use for custom type tests
-      pp = <<-EOS
-        class { 'apache':
-            mpm_module => 'prefork',
-        }
-        include apache::mod::php
-        include postgresql::server
-
-        class { 'zabbix':
-          zabbix_version   => '3.0', # zabbixapi gem doesn't currently support higher versions
-          zabbix_url       => 'localhost',
-          zabbix_api_user  => 'Admin',
-          zabbix_api_pass  => 'zabbix',
-          apache_use_ssl   => false,
-          manage_resources => true,
-          require          => [ Class['postgresql::server'], Class['apache'], ],
-        }
-
-        zabbix_proxy { 'ZabbixProxy1':
-          ipaddress => '127.0.0.1',
-          use_ip    => true,
-          mode      => 0,
-          port      => 10051,
-          require   => [ Service['zabbix-server'], Package['zabbixapi'], ],
-        }
-        zabbix_proxy { 'ZabbixProxy2':
-          ipaddress => '127.0.0.3',
-          use_ip    => false,
-          mode      => 1,
-          port      => 10055,
-          require   => [ Service['zabbix-server'], Package['zabbixapi'], ],
-        }
-      EOS
-
-      shell('yum clean metadata') if fact('os.family') == 'RedHat'
-
-      # Cleanup old database
-      cleanup_zabbix
-
-      apply_manifest(pp, catch_failures: true)
+    # This will deploy a running Zabbix setup (server, web, db) which we can
+    # use for custom type tests
+    pp1 = <<-EOS
+      $compile_packages = $facts['os']['family'] ? {
+        'RedHat' => [ 'make', 'gcc-c++', 'rubygems', 'ruby'],
+        'Debian' => [ 'make', 'g++', 'ruby-dev', 'ruby', 'pkg-config',],
+        default  => [],
+      }
+      ensure_packages($compile_packages, { before => Package['zabbixapi'], })
+      class { 'apache':
+        mpm_module => 'prefork',
+      }
+      include apache::mod::php
+      include postgresql::server
+
+      class { 'zabbix':
+        zabbix_version   => '3.0', # zabbixapi gem doesn't currently support higher versions
+        zabbix_url       => 'localhost',
+        zabbix_api_user  => 'Admin',
+        zabbix_api_pass  => 'zabbix',
+        apache_use_ssl   => false,
+        manage_resources => true,
+        require          => [ Class['postgresql::server'], Class['apache'], ],
+      }
+    EOS
+
+    # Cleanup old database
+    cleanup_zabbix
+
+    it 'works idempotently with no errors' do
+      # Run it twice and test for idempotency
+      apply_manifest(pp1, catch_failures: true)
+      apply_manifest(pp1, catch_changes: true)
+    end
+
+    # setup proxies within zabbix
+    pp2 = <<-EOS
+      zabbix_proxy { 'ZabbixProxy1':
+        mode => 0,
+      }
+      zabbix_proxy { 'ZabbixProxy2':
+        ipaddress => '127.0.0.3',
+        use_ip    => false,
+        mode      => 1,
+        port      => 10055,
+      }
+    EOS
+
+    it 'works idempotently with no errors' do
+      # Run it twice and test for idempotency
+      apply_manifest(pp2, catch_failures: true)
+      apply_manifest(pp2, catch_changes: true)
     end
 
     let(:result_proxies) do
@@ -87,27 +97,81 @@ class { 'zabbix':
     end
   end
 
+  context 'update zabbix_proxy resources' do
+    # This will update the Zabbix proxies created above by switching their configuration
+    pp_update = <<-EOS
+      zabbix_proxy { 'ZabbixProxy1':
+        ipaddress => '127.0.0.3',
+        use_ip    => false,
+        mode      => 1,
+        port      => 10055,
+      }
+      zabbix_proxy { 'ZabbixProxy2':
+        mode => 0,
+      }
+    EOS
+
+    it 'works idempotently with no errors' do
+      # Run it twice and test for idempotency
+      apply_manifest(pp_update, catch_failures: true)
+      apply_manifest(pp_update, catch_changes: true)
+    end
+
+    let(:result_proxies) do
+      zabbixapi('localhost', 'Admin', 'zabbix', 'proxy.get', selectInterface: %w[dns ip port useip],
+                                                             output: ['host']).result
+    end
+
+    context 'ZabbixProxy1' do
+      let(:proxy1) { result_proxies.select { |h| h['host'] == 'ZabbixProxy1' }.first }
+
+      it 'is created' do
+        expect(proxy1['host']).to eq('ZabbixProxy1')
+      end
+
+      it 'has a interfaces dns configured' do
+        expect(proxy1['interface']['dns']).to eq('ZabbixProxy1')
+      end
+      it 'has a interfaces ip configured' do
+        expect(proxy1['interface']['ip']).to eq('127.0.0.3')
+      end
+      it 'has a interfaces port configured' do
+        expect(proxy1['interface']['port']).to eq('10055')
+      end
+      it 'has a interfaces useip configured' do
+        expect(proxy1['interface']['useip']).to eq('0')
+      end
+    end
+
+    context 'ZabbixProxy2' do
+      let(:proxy2) { result_proxies.select { |h| h['host'] == 'ZabbixProxy2' }.first }
+
+      it 'is created' do
+        expect(proxy2['host']).to eq('ZabbixProxy2')
+      end
+
+      it 'has no interfaces configured' do
+        # Active proxies do not have interface
+        expect(proxy2['interface']).to eq([])
+      end
+    end
+  end
+
   context 'delete zabbix_proxy resources' do
-    it 'runs successfully' do
-      # This will delete the Zabbix proxies create above
-      pp = <<-EOS
-        zabbix_proxy { 'ZabbixProxy1':
-          ensure    => absent,
-          ipaddress => '127.0.0.1',
-          use_ip    => true,
-          mode      => 0,
-          port      => 10051,
-        }
-        zabbix_proxy { 'ZabbixProxy2':
-          ensure    => absent,
-          ipaddress => '127.0.0.3',
-          use_ip    => false,
-          mode      => 1,
-          port      => 10055,
-        }
-      EOS
-
-      apply_manifest(pp, catch_failures: true)
+    # This will delete the Zabbix proxies create above
+    pp_delete = <<-EOS
+      zabbix_proxy { 'ZabbixProxy1':
+        ensure => absent,
+      }
+      zabbix_proxy { 'ZabbixProxy2':
+        ensure => absent,
+      }
+    EOS
+
+    it 'works idempotently with no errors' do
+      # Run it twice and test for idempotency
+      apply_manifest(pp_delete, catch_failures: true)
+      apply_manifest(pp_delete, catch_changes: true)
     end
 
     let(:result_proxies) do