Merge pull request #203 from ekohl/smaller-puppet-facter-map

Only store facter versions in JSON

Author: bastelfreak

README.md

@@ -572,7 +572,7 @@ When no facts are available for the specific facter/operating system combination
 ## Maintenance
 
 This gem uses information about puppet AIO component versions to build/test.
-They are vendored at `ext/puppet_agent_components.json`. If they are outdated,
+They are stored at `ext/puppet_agent_facter_versions.json`. If they are outdated,
 the `puppet_versions:test` rake task will fail and they need to be updated.
 This is as easy as running: `bundle exec rake puppet_versions:update`
 

Rakefile

@@ -1,4 +1,4 @@
-PUPPET_VERSIONS_PATH = File.join(__dir__, 'ext', 'puppet_agent_components.json')
+PUPPET_VERSIONS_PATH = File.join(__dir__, 'ext', 'puppet_agent_facter_versions.json')
 
 begin
   require 'rspec/core/rake_task'
@@ -31,9 +31,14 @@ namespace :puppet_versions do
     response = http.request(request)
     raise unless response.is_a?(Net::HTTPSuccess)
 
-    File.open(PUPPET_VERSIONS_PATH, 'wb:UTF-8') do |fd|
-      fd.write(JSON.pretty_generate(JSON.parse(response.body)))
+    data = JSON.parse(response.body).filter_map do |_, versions|
+      if !versions['puppet'].nil? && !versions['facter'].nil?
+        [versions['puppet'], versions['facter']]
+      end
     end
+    data.sort_by! { |puppet, _facter| Gem::Version.new(puppet) }.reverse!
+
+    File.write(PUPPET_VERSIONS_PATH, "#{JSON.pretty_generate(data.to_h)}\n")
   end
 
   task :test do