fixed bug on embedded-schedule: when clicking talk, nothing was happening

Author: fcamblor

mobile/src/views/event/EmbeddedSchedulePage.vue

@@ -1,6 +1,6 @@
 <template>
   <ion-page v-themed-event-styles="confDescriptor">
-    <schedule-page :hide-header="true" :hide-watch-later="true"></schedule-page>
+    <schedule-page :hide-header="true" :hide-watch-later="true" :emit-event-on-talk-clicked="true" @talk-clicked="openTalk"></schedule-page>
     <ion-footer>
       <em>
         {{ LL.Open_full_version_of_the_schedule() }}
@@ -13,11 +13,16 @@
 </template>
 <script setup lang="ts">
 import {SchedulePage} from "@/router/preloaded-pages";
-import {IonFooter} from "@ionic/vue";
+import {IonFooter, useIonRouter} from "@ionic/vue";
 import {useSharedConferenceDescriptor} from "@/state/useConferenceDescriptor";
 import {typesafeI18n} from "@/i18n/i18n-vue";
-import {getResolvedEventRootPathFromSpacedEventIdRef, useCurrentSpaceEventIdRef} from "@/services/Spaces";
+import {
+  getResolvedEventRootPath,
+  getResolvedEventRootPathFromSpacedEventIdRef,
+  useCurrentSpaceEventIdRef
+} from "@/services/Spaces";
 import {computed} from "vue";
+import {VoxxrinTalk} from "@/models/VoxxrinTalk";
 
 const appBaseUrl = import.meta.env.VITE_WHITE_LABEL_PUBLIC_URL;
 const appBaseUrlWithoutTrailingSlash = appBaseUrl.substring(0, appBaseUrl.length - (appBaseUrl[appBaseUrl.length-1]==='/'?1:0));
@@ -26,11 +31,16 @@ const spacedEventIdRef = useCurrentSpaceEventIdRef()
 const {conferenceDescriptor: confDescriptor} = useSharedConferenceDescriptor(spacedEventIdRef);
 
 const fullScheduleUrl = computed(() => {
-  return `${appBaseUrlWithoutTrailingSlash}/${getResolvedEventRootPathFromSpacedEventIdRef(spacedEventIdRef)}`
+  return `${appBaseUrlWithoutTrailingSlash}${getResolvedEventRootPathFromSpacedEventIdRef(spacedEventIdRef)}`
 })
 
 const { LL } = typesafeI18n()
+const spaceEventIdRef = useCurrentSpaceEventIdRef();
+const router = useIonRouter();
 
+const openTalk = (talk: VoxxrinTalk) => {
+  router.push(`${getResolvedEventRootPath(spaceEventIdRef.value.eventId, spaceEventIdRef.value.spaceToken)}/talks/${talk.id.value}/details`)
+}
 </script>
 <style scoped lang="scss">
 ion-footer {

mobile/src/views/event/SchedulePage.vue

@@ -165,9 +165,18 @@ const props = defineProps({
         require: false,
         type: Boolean,
         default: false
+    },
+    emitEventOnTalkClicked: {
+        required: false,
+        type: Boolean,
+        default: false,
     }
 })
 
+const emits = defineEmits<{
+  (event: 'talk-clicked', talk: VoxxrinTalk): void,
+}>()
+
 const spacedEventId = useCurrentSpaceEventIdRef()
 const {conferenceDescriptor: confDescriptor} = useSharedConferenceDescriptor(spacedEventId);
 
@@ -241,14 +250,18 @@ async function navigateToTalkRatingScreenFor(talk: VoxxrinTalk) {
 
 async function openTalkDetails(talk: VoxxrinTalk) {
     if(talk) {
-        // TODO: Re-enable this once *tabbed* talk details as feedback viewer routing has been fixed
-        // const talkFeedbackViewerToken = toValue(talkFeedbackViewerTokensRef)?.find(t => t.talkId.isSameThan(talk.id));
-        // const url = talkFeedbackViewerToken
-        //   ?`/events/${eventId.value.value}/talks/${talk.id.value}/asFeedbackViewer/${talkFeedbackViewerToken.secretToken}/details`
-        //   :`/events/${eventId.value.value}/talks/${talk.id.value}/details`
-        const url = `${getResolvedEventRootPathFromSpacedEventIdRef(spacedEventId)}/talks/${talk.id.value}/details`
-
-        triggerTabbedPageNavigate(url, "forward", "push");
+        if(props.emitEventOnTalkClicked) {
+          emits('talk-clicked', talk);
+        } else {
+          // TODO: Re-enable this once *tabbed* talk details as feedback viewer routing has been fixed
+          // const talkFeedbackViewerToken = toValue(talkFeedbackViewerTokensRef)?.find(t => t.talkId.isSameThan(talk.id));
+          // const url = talkFeedbackViewerToken
+          //   ?`/events/${eventId.value.value}/talks/${talk.id.value}/asFeedbackViewer/${talkFeedbackViewerToken.secretToken}/details`
+          //   :`/events/${eventId.value.value}/talks/${talk.id.value}/details`
+          const url = `${getResolvedEventRootPathFromSpacedEventIdRef(spacedEventId)}/talks/${talk.id.value}/details`
+
+          triggerTabbedPageNavigate(url, "forward", "push");
+        }
     }
 }