throwing error in deleteUserRefIncludingChildren() when user has a tokens-wallet entry, so that it can be considered as a failure in overall statistics

Author: fcamblor

cloud/functions/src/functions/firestore/services/user-utils.ts

@@ -132,7 +132,7 @@ async function deleteUserRefIncludingChildren(userRef: DocumentReference<Documen
     || (walletSecrets.talkFeedbacksViewerTokens && walletSecrets.talkFeedbacksViewerTokens.length)
   )) {
     console.info(`Not deleting user ${userRef.id} because he has tokens-wallet non-empty collection`)
-    return;
+    throw new Error(`Not deleting user ${userRef.id} because he has tokens-wallet non-empty collection`)
   }
 
   const preferencesDoc = await db.doc(`${userRef.path}/preferences/self`).get()

cloud/functions/src/functions/http/api/admin-routes.ts

@@ -32,7 +32,7 @@ export function declareAdminHttpRoutes(app: Express) {
     async (res, path, { dryRun, force }, body) => {
       const results = await (await import("../../../cron/cleanOutdatedUsers")).cleanOutdatedUsers({ dryRun, force });
       return sendResponseMessage(res, 200, {
-        message: `${results.totalDeletedUsers} users have been deleted (in ${results.totalDuration}ms) !`,
+        message: `${results.totalDeletedUsers} users have been deleted and ${results.failures} have failed to be deleted (in ${results.totalDuration}ms) !`,
         results
       })
     })