Skip to content

Commit 30839bb

Browse files
committed
fixed bad ETag impl on talksEditors
1 parent 5faa17b commit 30839bb

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

cloud/functions/src/functions/http/api/events-routes.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ export function declareEventHttpRoutes(app: Express) {
7474
}),
7575
ensureHasFamilyOrEventOrganizerToken(),
7676
async (res, path, query, eventDescriptor, req) =>
77-
(await import("../event/talkFeedbacksViewers")).eventTalkFeedbacksViewers(res, path, query, req, eventDescriptor));
77+
(await import("../event/talksEditors")).eventTalksEditors(res, path, query, req, eventDescriptor));
7878
Routes.get(app, '/events/:eventId/talks/:talkId/feedbacks',
7979
z.object({
8080
query: z.object({

cloud/functions/src/functions/http/event/talkFeedbacksViewers.ts renamed to cloud/functions/src/functions/http/event/talksEditors.ts

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,17 @@ import * as express from "express";
55
import {ConferenceDescriptor} from "../../../../../../shared/conference-descriptor.firestore";
66

77

8-
export async function eventTalkFeedbacksViewers(
8+
export async function eventTalksEditors(
99
response: express.Response,
1010
pathParams: {eventId: string},
1111
queryParams: {token: string, baseUrl: string},
1212
request: express.Request,
1313
eventDescriptor: ConferenceDescriptor
1414
) {
1515

16-
const { cachedHash, updatesDetected } = await checkEventLastUpdate(pathParams.eventId, [root => root.talkListUpdated], request, response)
16+
const { cachedHash, updatesDetected } = await checkEventLastUpdate(pathParams.eventId, [
17+
root => root.talkListUpdated
18+
], request, response)
1719
if(!updatesDetected) {
1820
return sendResponseMessage(response, 304)
1921
}
@@ -25,10 +27,10 @@ export async function eventTalkFeedbacksViewers(
2527
...tfvt,
2628
registrationUrl: `${queryParams.baseUrl}${queryParams.baseUrl.endsWith("/")?"":"/"}user-tokens/register?type=TalkFeedbacksViewer&eventId=${tfvt.eventId}&talkId=${tfvt.talkId}&secretToken=${tfvt.secretToken}`
2729
})
28-
));
29-
} catch(error) {
30-
sendResponseMessage(response, 500, ""+error, cachedHash ? {
31-
'ETag': cachedHash
30+
), cachedHash ? {
31+
'ETag': cachedHash
3232
}:{});
33+
} catch(error) {
34+
sendResponseMessage(response, 500, ""+error);
3335
}
3436
}

0 commit comments

Comments
 (0)