event-level talk feedbacks should be stored as a collection instead of a document with embedded array

Author: fcamblor

cloud/functions/src/crawlers/crawl.ts

@@ -11,9 +11,7 @@ import {CAMPING_DES_SPEAKERS_CRAWLER} from "./camping-des-speakers/crawler";
 import {DEVOXX_SCALA_CRAWLER} from "./devoxx-scala/crawler";
 import {match} from "ts-pattern";
 import {v4 as uuidv4} from "uuid"
-import {DetailedTalk} from "../../../../shared/daily-schedule.firestore";
 import {ConferenceOrganizerSpace} from "../../../../shared/conference-organizer-space.firestore";
-import {TalkAttendeeFeedback, TalkFeedbacks} from "../../../../shared/talk-feedbacks.firestore";
 const axios = require('axios');
 
 export type CrawlerKind<ZOD_TYPE extends z.ZodType> = {
@@ -155,14 +153,12 @@ const saveEvent = async function(event: FullEvent) {
             // If token already exists for the talk, let's not add it
             if(!existingTalkFeedbackViewerToken) {
                 const talkFeedbackViewerSecretToken = uuidv4();
-                const talkFeedbacks: TalkFeedbacks = {
-                    attendeeFeedbacks: []
-                }
 
                 await firestoreEvent
                     .collection("talks").doc(talk.id)
-                    .collection("feedbacks").doc(talkFeedbackViewerSecretToken)
-                    .set(talkFeedbacks)
+                    .collection("feedbacks-access").doc(talkFeedbackViewerSecretToken)
+                    // Creating a fake entry so that feedbacks-access/{secretToken} node is created
+                    .collection('_empty').add({ _: 42 })
 
                 organizerSpaceContent.talkFeedbackViewerTokens.push({
                     eventId: event.id,

cloud/functions/src/functions/firestore/onTalkFeedbackProvided.ts

@@ -3,7 +3,7 @@ import {UserDailyFeedbacks, UserFeedback} from "../../../../../shared/feedbacks.
 import {db} from "../../firebase";
 import {getSecretTokenDoc} from "./firestore-utils";
 import {ConferenceOrganizerSpace} from "../../../../../shared/conference-organizer-space.firestore";
-import {TalkAttendeeFeedback, TalkFeedbacks} from "../../../../../shared/talk-feedbacks.firestore";
+import {TalkAttendeeFeedback} from "../../../../../shared/talk-feedbacks.firestore";
 import {UserTokensWallet} from "../../../../../shared/user-tokens-wallet.firestore";
 
 
@@ -49,8 +49,8 @@ async function updateTalkFeedbacksFromUserFeedbacks(userId: string, eventId: str
                 throw new Error(`Unexpected unexistant user token wallet for userId=${userId}`);
             }
 
-            const talkFeedbacks = (await db.doc(`events/${eventId}/talks/${feedback.talkId}/feedbacks/${talkFeedbackViewerToken.secretToken}`).get()).data() as TalkFeedbacks|undefined
-                || { attendeeFeedbacks: [] };
+            const userPublicTokensHavingProvidedFeedback = ((await db.collection(`events/${eventId}/talks/${feedback.talkId}/feedbacks-access/${talkFeedbackViewerToken.secretToken}/feedbacks`).listDocuments())
+                || []).map(d => d.id)
 
             const attendeeFeedback: TalkAttendeeFeedback = {
                 talkId: feedback.talkId,
@@ -61,14 +61,7 @@ async function updateTalkFeedbacksFromUserFeedbacks(userId: string, eventId: str
                 attendeePublicToken: userTokensWallet.publicUserToken
             }
 
-            const afIndex = talkFeedbacks.attendeeFeedbacks.findIndex(af => af.talkId === feedback.talkId);
-            if(afIndex === -1) {
-                talkFeedbacks.attendeeFeedbacks.push(attendeeFeedback);
-            } else {
-                talkFeedbacks.attendeeFeedbacks[afIndex] = attendeeFeedback;
-            }
-
-            await db.doc(`events/${eventId}/talks/${feedback.talkId}/feedbacks/${talkFeedbackViewerToken.secretToken}`).set(talkFeedbacks);
+            await db.doc(`events/${eventId}/talks/${feedback.talkId}/feedbacks-access/${talkFeedbackViewerToken.secretToken}/feedbacks/${userTokensWallet.publicUserToken}`).set(attendeeFeedback)
         }
     }))
 }

shared/talk-feedbacks.firestore.d.ts

@@ -1,9 +1,5 @@
 import {ISODatetime} from "./type-utils";
 
-export type TalkFeedbacks = {
-    attendeeFeedbacks: TalkAttendeeFeedback[]
-}
-
 export type TalkAttendeeFeedback = {
     talkId: string,
     attendeePublicToken: string;