Skip to content

Commit 762dcea

Browse files
committed
#46 removed talk details page as feedback viewer, as it poses navigation issues due to tabbed page in a popup
1 parent dc9be70 commit 762dcea

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

mobile/src/views/event/SchedulePage.vue

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -235,10 +235,12 @@ async function navigateToTalkRatingScreenFor(talk: VoxxrinTalk) {
235235
236236
async function openTalkDetails(talk: VoxxrinTalk) {
237237
if(talk) {
238-
const talkFeedbackViewerToken = toValue(talkFeedbackViewerTokensRef)?.find(t => t.talkId.isSameThan(talk.id));
239-
const url = talkFeedbackViewerToken
240-
?`/events/${eventId.value.value}/talks/${talk.id.value}/asFeedbackViewer/${talkFeedbackViewerToken.secretToken}/details`
241-
:`/events/${eventId.value.value}/talks/${talk.id.value}/details`
238+
// TODO: Re-enable this once *tabbed* talk details as feedback viewer routing has been fixed
239+
// const talkFeedbackViewerToken = toValue(talkFeedbackViewerTokensRef)?.find(t => t.talkId.isSameThan(talk.id));
240+
// const url = talkFeedbackViewerToken
241+
// ?`/events/${eventId.value.value}/talks/${talk.id.value}/asFeedbackViewer/${talkFeedbackViewerToken.secretToken}/details`
242+
// :`/events/${eventId.value.value}/talks/${talk.id.value}/details`
243+
const url = `/events/${eventId.value.value}/talks/${talk.id.value}/details`
242244
243245
triggerTabbedPageNavigate(url, "forward", "push");
244246
}

0 commit comments

Comments
 (0)