removed talk's feedback updatedSince query param, which is not good compared to ETag

Author: fcamblor

cloud/functions/src/functions/firestore/firestore-utils.ts

@@ -50,7 +50,7 @@ export async function getOrganizerSpaceByToken(
     return organizerSpace;
 }
 
-export async function ensureTalkFeedbackViewerTokenIsValidThenGetFeedbacks(eventId: string, talkId: string, talkViewerToken: string, updatedSince: Date) {
+export async function ensureTalkFeedbackViewerTokenIsValidThenGetFeedbacks(eventId: string, talkId: string, talkViewerToken: string) {
     const feedbacksRefs = await db.collection(
         `events/${eventId}/talks/${talkId}/feedbacks-access/${talkViewerToken}/feedbacks`
     ).listDocuments()
@@ -63,7 +63,7 @@ export async function ensureTalkFeedbackViewerTokenIsValidThenGetFeedbacks(event
     const feedbackSnapshots = await Promise.all(feedbacksRefs.map(ref => ref.get()))
     const feedbacks = feedbackSnapshots.map(snap => snap.data() as TalkAttendeeFeedback)
 
-    return feedbacks.filter(feedback => Date.parse(feedback.lastUpdatedOn) > updatedSince.getTime());
+    return feedbacks;
 }
 
 export async function eventTalkStatsFor(eventId: string): Promise<TalkStats[]> {

cloud/functions/src/functions/http/event/legacy/deprecatedAttendeesFeedbacks.ts

@@ -22,17 +22,10 @@ export async function legacyAttendeesFeedbacks(request: functions.https.Request,
     const familyToken = extractSingleQueryParam(request, 'familyToken');
     const familyOrganizerSecretToken = extractSingleQueryParam(request, 'familyOrganizerSecretToken');
     const eventId = extractSingleQueryParam(request, 'eventId');
-    let sinceTimestamp = Date.parse(extractSingleQueryParam(request, 'updatedSince') || "");
-
-    // TODO: Remove me
-    if(isNaN(sinceTimestamp)) {
-        sinceTimestamp = Date.parse("1970-01-01T00:00:00Z")
-    }
 
     if(!talkIds || !talkIds.length) { return sendResponseMessage(response, 400, `Missing [talkIds] (multi) query parameter !`) }
     if(!eventId) { return sendResponseMessage(response, 400, `Missing [eventId] query parameter !`) }
     if(!organizerSecretToken && !familyToken && !familyOrganizerSecretToken) { return sendResponseMessage(response, 400, `Missing either [organizerSecretToken] or [familyToken] or [familyOrganizerSecretToken] query parameter !`) }
-    if(isNaN(sinceTimestamp)) { return sendResponseMessage(response, 400, `Missing valid [updatedSince] query parameter !`) }
 
     const eventDescriptor = await getEventDescriptor(eventId);
     if(familyOrganizerSecretToken) {
@@ -54,8 +47,6 @@ export async function legacyAttendeesFeedbacks(request: functions.https.Request,
     //     return sendResponseMessage(response, 304)
     // }
 
-    const updatedSince = new Date(sinceTimestamp);
-
     try {
         const organizerSpace = await match([organizerSecretToken, familyToken, familyOrganizerSecretToken])
             .with([ P.nullish, P.nullish, P.nullish ], async ([_1, _2]) => { throw new Error(`Unexpected state: (undefined,undefined)`); })
@@ -71,7 +62,7 @@ export async function legacyAttendeesFeedbacks(request: functions.https.Request,
             .filter(talkFeedbacksViewerToken => talkIds.includes(talkFeedbacksViewerToken.talkId))
             .map(async (talkFeedbackViewerToken) => {
 
-            const feedbacks = await ensureTalkFeedbackViewerTokenIsValidThenGetFeedbacks(talkFeedbackViewerToken.eventId, talkFeedbackViewerToken.talkId, talkFeedbackViewerToken.secretToken, updatedSince);
+            const feedbacks = await ensureTalkFeedbackViewerTokenIsValidThenGetFeedbacks(talkFeedbackViewerToken.eventId, talkFeedbackViewerToken.talkId, talkFeedbackViewerToken.secretToken);
 
             // Enriching bingo entries with label
             const enrichedFeedbacks = feedbacks.map(feedback => ({

cloud/functions/src/functions/http/event/talkFeedbacks.ts

@@ -11,10 +11,6 @@ import {ISODatetime} from "../../../../../../shared/type-utils";
 
 export async function eventTalkFeedbacks(response: Response, pathParams: {eventId: string, talkId: string}, queryParams: {token: string, updatedSince?: ISODatetime|undefined }, request: Request, eventDescriptor: ConferenceDescriptor) {
 
-    const updatedSince = queryParams.updatedSince || "1970-01-01T00:00:00Z";
-    const sinceTimestamp = Date.parse(updatedSince);
-    if(isNaN(sinceTimestamp)) { return sendResponseMessage(response, 400, `Missing valid [updatedSince] query parameter !`) }
-
     const { eventId, talkId } = pathParams
 
     const { cachedHash, updatesDetected } = await checkEventLastUpdate(eventId, [
@@ -34,7 +30,7 @@ export async function eventTalkFeedbacks(response: Response, pathParams: {eventI
           .filter(talkFeedbacksViewerToken => talkId === talkFeedbacksViewerToken.talkId)
           .map(async (talkFeedbackViewerToken) => {
 
-            const feedbacks = await ensureTalkFeedbackViewerTokenIsValidThenGetFeedbacks(talkFeedbackViewerToken.eventId, talkFeedbackViewerToken.talkId, talkFeedbackViewerToken.secretToken, new Date(sinceTimestamp));
+            const feedbacks = await ensureTalkFeedbackViewerTokenIsValidThenGetFeedbacks(talkFeedbackViewerToken.eventId, talkFeedbackViewerToken.talkId, talkFeedbackViewerToken.secretToken);
 
             // Enriching bingo entries with label
             const enrichedFeedbacks = feedbacks.map(feedback => ({