getting rid of explicit orderBy(documentId) as this doesn't play well when we have where clauses

Author: fcamblor

cloud/functions/src/functions/firestore/migrations/025-fillUserLastConnection.ts

@@ -12,8 +12,7 @@ export async function fillUserLastConnection(): Promise<"OK"|"Error"> {
   const stats = await windowedProcessUsers(
     (maybeLastPreviousUserDoc) => match(maybeLastPreviousUserDoc)
       .with(P.nullish, () => db.collection('users'))
-      .otherwise(lastPreviousUserDoc => db.collection('users').where(FieldPath.documentId(), '>', lastPreviousUserDoc.id))
-      .orderBy(FieldPath.documentId(), 'asc'),
+      .otherwise(lastPreviousUserDoc => db.collection('users').where(FieldPath.documentId(), '>', lastPreviousUserDoc.id)),
     async userDoc => {
       const user = userDoc.data();
       if(!user.userLastConnection) {

cloud/functions/src/functions/firestore/services/user-utils.ts

@@ -41,7 +41,6 @@ export async function cleanOutdatedUsers(opts: { force: boolean, dryRun: boolean
         .with(P.nullish,
           () => baseQuery
         ).otherwise(maybeLastPreviousUserDoc => baseQuery.where(FieldPath.documentId(), '>', maybeLastPreviousUserDoc.id))
-        .orderBy(FieldPath.documentId(), 'asc')
     },
     userDoc => deleteUserRefIncludingChildren(userDoc.ref, opts),
   )