Skip to content

Commit 576b6e9

Browse files
authored
Merge pull request #149 from jcoady/master
Updates for JupyterLab3 prebuilt extension
2 parents 59dcc85 + adbc4ee commit 576b6e9

File tree

2 files changed

+50
-28
lines changed

2 files changed

+50
-28
lines changed

labextension/vpython/package.json

Lines changed: 43 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,24 @@
11
{
22
"name": "vpython",
3-
"version": "3.0.0",
3+
"version": "3.0.3",
44
"description": "VPython extension for JupyterLab",
55
"keywords": [
66
"jupyter",
77
"jupyterlab",
88
"jupyterlab-extension"
99
],
10-
"homepage": "",
10+
"homepage": "https://github.com/jcoady/jupyterlab_vpython",
1111
"bugs": {
12-
"url": ""
12+
"url": "https://github.com/jcoady/jupyterlab_vpython/issues"
1313
},
1414
"license": "BSD-3-Clause",
15-
"author": "John Coady",
15+
"author": {
16+
"name": "John Coady",
17+
"email": "[email protected]"
18+
},
1619
"files": [
1720
"lib/**/*.{d.ts,eot,gif,html,jpg,js,js.map,json,png,svg,woff2,ttf,otf,ico}",
18-
"style/**/*.{css,eot,gif,html,jpg,json,png,svg,woff2,ttf,otf,ico}",
21+
"style/**/*.{css,.js,eot,gif,html,jpg,json,png,svg,woff2,ttf,otf,ico}",
1922
"vpython_data/*.{css,eot,gif,html,jpg,json,png,svg,woff2,ttf,otf,ico}",
2023
"vpython_libraries/*"
2124
],
@@ -24,39 +27,53 @@
2427
"style": "style/index.css",
2528
"repository": {
2629
"type": "git",
27-
"url": ""
30+
"url": "https://github.com/jcoady/jupyterlab_vpython.git"
2831
},
2932
"scripts": {
30-
"build": "tsc",
31-
"clean": "rimraf lib tsconfig.tsbuildinfo",
33+
"build": "jlpm run build:lib && jlpm run build:labextension:dev",
34+
"build:prod": "jlpm run clean && jlpm run build:lib && jlpm run build:labextension",
35+
"build:labextension": "jupyter labextension build .",
36+
"build:labextension:dev": "jupyter labextension build --development True .",
37+
"build:lib": "tsc",
38+
"clean": "jlpm run clean:lib",
39+
"clean:lib": "rimraf lib tsconfig.tsbuildinfo",
40+
"clean:labextension": "rimraf jupyterlab_vpython/labextension",
41+
"clean:all": "jlpm run clean:lib && jlpm run clean:labextension",
3242
"eslint": "eslint . --ext .ts,.tsx --fix",
3343
"eslint:check": "eslint . --ext .ts,.tsx",
34-
"prepare": "jlpm run clean && jlpm run build",
35-
"watch": "tsc -w"
44+
"install:extension": "jlpm run build",
45+
"watch": "run-p watch:src watch:labextension",
46+
"watch:src": "tsc -w",
47+
"watch:labextension": "jupyter labextension watch ."
3648
},
3749
"dependencies": {
38-
"@jupyterlab/application": "3.0.9",
39-
"@jupyterlab/apputils": "3.0.7",
40-
"@jupyterlab/coreutils": "5.0.5",
41-
"@jupyterlab/docregistry": "3.0.9",
42-
"@jupyterlab/notebook": "3.0.9",
43-
"@lumino/disposable": "^1.5.0",
50+
"@jupyterlab/application": "^3.0.9",
51+
"@jupyterlab/apputils": "^3.0.7",
52+
"@jupyterlab/coreutils": "^5.0.5",
53+
"@jupyterlab/docregistry": "^3.0.9",
54+
"@jupyterlab/notebook": "^3.0.9",
55+
"@lumino/disposable": "^1.6.0",
4456
"script-loader": "^0.7.2"
4557
},
4658
"devDependencies": {
47-
"@typescript-eslint/eslint-plugin": "^2.25.0",
48-
"@typescript-eslint/parser": "^2.25.0",
49-
"eslint": "^6.8.0",
50-
"eslint-config-prettier": "^6.10.1",
51-
"eslint-plugin-prettier": "^3.1.2",
52-
"prettier": "1.16.4",
53-
"rimraf": "^2.6.1",
54-
"typescript": "~3.7.0"
59+
"@jupyterlab/builder": "^3.0.0",
60+
"@typescript-eslint/eslint-plugin": "^4.8.1",
61+
"@typescript-eslint/parser": "^4.8.1",
62+
"eslint": "^7.14.0",
63+
"eslint-config-prettier": "^6.15.0",
64+
"eslint-plugin-prettier": "^3.1.4",
65+
"npm-run-all": "^4.1.5",
66+
"prettier": "^2.1.1",
67+
"rimraf": "^3.0.2",
68+
"typescript": "~4.1.3"
5569
},
5670
"sideEffects": [
57-
"style/*.css"
71+
"style/*.css",
72+
"style/index.js"
5873
],
74+
"styleModule": "style/index.js",
5975
"jupyterlab": {
60-
"extension": true
76+
"extension": true,
77+
"outputDir": "jupyterlab_vpython/labextension"
6178
}
6279
}

labextension/vpython/src/glowcommlab.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,13 @@ export function setupWebsocket(msg,serviceUrl) {
8383
wscheckfontsloaded(msg,serviceUrl)
8484
}
8585

86-
var datadir = '/static/lab/vpython_data/'
87-
window.Jupyter_VPython = "/static/lab/vpython_data/" // prefix used by glow.min.js for textures
86+
// Old datadir value for a source extension npm package. (used prior to JupyterLab 3.0)
87+
//var datadir = '/static/lab/vpython_data/'
88+
//window.Jupyter_VPython = "/static/lab/vpython_data/" // prefix used by glow.min.js for textures
89+
90+
// New datadir value for a prebuilt extension (new in JupyterLab 3.0)
91+
var datadir = '/lab/extensions/vpython/static/vpython_data/'
92+
window.Jupyter_VPython = "/lab/extensions/vpython/static/vpython_data/" // prefix used by glow.min.js for textures
8893

8994
function fontloading() {
9095
"use strict";

0 commit comments

Comments
 (0)