Skip to content

Commit 7b868d6

Browse files
authored
Merge pull request #151 from jcoady/master
Added isjupyterlab_vpython check
2 parents 322ec84 + 260fcea commit 7b868d6

File tree

3 files changed

+58
-42
lines changed

3 files changed

+58
-42
lines changed

labextension/vpython/src/glowcommlab.js

Lines changed: 20 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ import '!!file-loader?name=/vpython_data/[name].[ext]!../vpython_data/wood_textu
3030
export var comm
3131
var ws = null
3232
var isopen = false
33+
var isjupyterlab_vpython = true
3334

3435
console.log('START OF GLOWCOMM')
3536

@@ -819,20 +820,25 @@ function handle_cmds(dcmds) {
819820
case 'local_light': {glowObjs[idx] = local_light(cfg); break}
820821
case 'distant_light': {glowObjs[idx] = distant_light(cfg); break}
821822
case 'canvas': {
822-
var container = document.getElementById("glowscript");
823-
if (container !== null) {
824-
window.__context = { glowscript_container: $("#glowscript").removeAttr("id")}
825-
}
826-
glowObjs[idx] = canvas(cfg)
827-
glowObjs[idx]['idx'] = idx
828-
try{
829-
glowObjs[idx].wrapper[0].addEventListener("contextmenu", function(event){
830-
event.preventDefault();
831-
event.stopPropagation();
832-
});
833-
}
834-
catch(err) {
835-
console.log("glowcomm canvas contextmenu event : ",err.message);
823+
if ((typeof isjupyterlab_vpython !== 'undefined') && (isjupyterlab_vpython === true)) {
824+
var container = document.getElementById("glowscript");
825+
if (container !== null) {
826+
window.__context = { glowscript_container: $("#glowscript").removeAttr("id")}
827+
}
828+
glowObjs[idx] = canvas(cfg)
829+
glowObjs[idx]['idx'] = idx
830+
try{
831+
glowObjs[idx].wrapper[0].addEventListener("contextmenu", function(event){
832+
event.preventDefault();
833+
event.stopPropagation();
834+
});
835+
}
836+
catch(err) {
837+
console.log("glowcomm canvas contextmenu event : ",err.message);
838+
}
839+
} else {
840+
glowObjs[idx] = canvas(cfg)
841+
glowObjs[idx]['idx'] = idx
836842
}
837843
break
838844
// Display frames per second and render time:

vpython/vpython_libraries/glowcomm.html

Lines changed: 19 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -723,20 +723,25 @@
723723
case 'local_light': {glowObjs[idx] = local_light(cfg); break}
724724
case 'distant_light': {glowObjs[idx] = distant_light(cfg); break}
725725
case 'canvas': {
726-
var container = document.getElementById("glowscript");
727-
if (container !== null) {
728-
window.__context = { glowscript_container: $("#glowscript").removeAttr("id")}
729-
}
730-
glowObjs[idx] = canvas(cfg)
731-
glowObjs[idx]['idx'] = idx
732-
try{
733-
glowObjs[idx].wrapper[0].addEventListener("contextmenu", function(event){
734-
event.preventDefault();
735-
event.stopPropagation();
736-
});
737-
}
738-
catch(err) {
739-
console.log("glowcomm canvas contextmenu event : ",err.message);
726+
if ((typeof isjupyterlab_vpython !== 'undefined') && (isjupyterlab_vpython === true)) {
727+
var container = document.getElementById("glowscript");
728+
if (container !== null) {
729+
window.__context = { glowscript_container: $("#glowscript").removeAttr("id")}
730+
}
731+
glowObjs[idx] = canvas(cfg)
732+
glowObjs[idx]['idx'] = idx
733+
try{
734+
glowObjs[idx].wrapper[0].addEventListener("contextmenu", function(event){
735+
event.preventDefault();
736+
event.stopPropagation();
737+
});
738+
}
739+
catch(err) {
740+
console.log("glowcomm canvas contextmenu event : ",err.message);
741+
}
742+
} else {
743+
glowObjs[idx] = canvas(cfg)
744+
glowObjs[idx]['idx'] = idx
740745
}
741746
break
742747
// Display frames per second and render time:

vpython/vpython_libraries/glowcomm.js

Lines changed: 19 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -774,20 +774,25 @@ function handle_cmds(dcmds) {
774774
case 'local_light': {glowObjs[idx] = local_light(cfg); break}
775775
case 'distant_light': {glowObjs[idx] = distant_light(cfg); break}
776776
case 'canvas': {
777-
var container = document.getElementById("glowscript");
778-
if (container !== null) {
779-
window.__context = { glowscript_container: $("#glowscript").removeAttr("id")}
780-
}
781-
glowObjs[idx] = canvas(cfg)
782-
glowObjs[idx]['idx'] = idx
783-
try{
784-
glowObjs[idx].wrapper[0].addEventListener("contextmenu", function(event){
785-
event.preventDefault();
786-
event.stopPropagation();
787-
});
788-
}
789-
catch(err) {
790-
console.log("glowcomm canvas contextmenu event : ",err.message);
777+
if ((typeof isjupyterlab_vpython !== 'undefined') && (isjupyterlab_vpython === true)) {
778+
var container = document.getElementById("glowscript");
779+
if (container !== null) {
780+
window.__context = { glowscript_container: $("#glowscript").removeAttr("id")}
781+
}
782+
glowObjs[idx] = canvas(cfg)
783+
glowObjs[idx]['idx'] = idx
784+
try{
785+
glowObjs[idx].wrapper[0].addEventListener("contextmenu", function(event){
786+
event.preventDefault();
787+
event.stopPropagation();
788+
});
789+
}
790+
catch(err) {
791+
console.log("glowcomm canvas contextmenu event : ",err.message);
792+
}
793+
} else {
794+
glowObjs[idx] = canvas(cfg)
795+
glowObjs[idx]['idx'] = idx
791796
}
792797
break
793798
// Display frames per second and render time:

0 commit comments

Comments
 (0)