Skip to content

Commit a2cbd05

Browse files
committed
Fix egregious error in glowcomm files
1 parent de94daf commit a2cbd05

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

labextension/vpython/src/glowcommlab.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -987,9 +987,9 @@ function handle_attrs(dattrs) {
987987
} else {
988988
if (triangle_quad.indexOf(attr) !== -1) {
989989
obj[attr] = glowObjs[val]
990-
} else if (attr = 'vs') {
991-
if (val.length == 3) obj[attr]['vs'] = [ glowObjs[val[0]], glowObjs[val[1]], glowObjs[val[2]] ]
992-
else obj[attr]['vs'] = [ glowObjs[val[0]], glowObjs[val[1]], glowObjs[val[2]], glowObjs[val[3]] ]
990+
} else if (attr == 'vs') {
991+
if (val.length == 3) obj['vs'] = [ glowObjs[val[0]], glowObjs[val[1]], glowObjs[val[2]] ]
992+
else obj['vs'] = [ glowObjs[val[0]], glowObjs[val[1]], glowObjs[val[2]], glowObjs[val[3]] ]
993993
} else {
994994
obj[attr] = val
995995
}

vpython/vpython_libraries/glowcomm.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -920,9 +920,9 @@
920920
} else {
921921
if (triangle_quad.indexOf(attr) !== -1) {
922922
obj[attr] = glowObjs[val]
923-
} else if (attr = 'vs') {
924-
if (val.length == 3) obj[attr]['vs'] = [ glowObjs[val[0]], glowObjs[val[1]], glowObjs[val[2]] ]
925-
else obj[attr]['vs'] = [ glowObjs[val[0]], glowObjs[val[1]], glowObjs[val[2]], glowObjs[val[3]] ]
923+
} else if (attr == 'vs') {
924+
if (val.length == 3) obj['vs'] = [ glowObjs[val[0]], glowObjs[val[1]], glowObjs[val[2]] ]
925+
else obj['vs'] = [ glowObjs[val[0]], glowObjs[val[1]], glowObjs[val[2]], glowObjs[val[3]] ]
926926
} else {
927927
obj[attr] = val
928928
}

vpython/vpython_libraries/glowcomm.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -963,9 +963,9 @@ function handle_attrs(dattrs) {
963963
} else {
964964
if (triangle_quad.indexOf(attr) !== -1) {
965965
obj[attr] = glowObjs[val]
966-
} else if (attr = 'vs') {
967-
if (val.length == 3) obj[attr]['vs'] = [ glowObjs[val[0]], glowObjs[val[1]], glowObjs[val[2]] ]
968-
else obj[attr]['vs'] = [ glowObjs[val[0]], glowObjs[val[1]], glowObjs[val[2]], glowObjs[val[3]] ]
966+
} else if (attr == 'vs') {
967+
if (val.length == 3) obj['vs'] = [ glowObjs[val[0]], glowObjs[val[1]], glowObjs[val[2]] ]
968+
else obj['vs'] = [ glowObjs[val[0]], glowObjs[val[1]], glowObjs[val[2]], glowObjs[val[3]] ]
969969
} else {
970970
obj[attr] = val
971971
}

0 commit comments

Comments
 (0)