关于社区插件审核修改

[RavenHogWarts]

obsidianmd/obsidian-releases#6792

• "fundingUrl": "https://github.com/vran-dev/obsidian-form-flow",, "fundingUrl": "https://github.com/vran-dev/obsidian-form-flow", This is meant for links to services like Buy me a coffee, GitHub sponsors and so on, if you don't have such a link remove this line.
• Copyright (C) 2020-2025 by Dynalist Inc. Please update this to the current year only and your name.
• You have two manifest.json files in your repo, please only have one to make it easier for you and open source contributors to manage and for me to review.
• action_type = "Action Type";, "Open Form in modal", "Open File in new tab" Use sentence case in UI
• style={{, this.containerEl.style.zIndex = "var(--form-overlay-layer)";, style={{ You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets.
• await app.vault.adapter.write(, const isExists = await app.vault.adapter.exists(parent);, await app.vault.adapter.mkdir(parent); Prefer the Vault API over the Adapter API
• window.addEventListener("keydown", this.handleKeyDown, true);, window.removeEventListener("keydown", this.handleKeyDown, true);, this.containerEl.addEventListener("keydown", this.tabEventHandler);, this.containerEl.removeEventListener("keydown", this.tabEventHandler); Use Scope.register to add keymap handlers to this scope. If that does not work for your use case, please explain why and register the event listeners using .registerDomEvent() instead.
• this.app.workspace.off(, this.app.vault.on("delete", this.fileDeleteListener);, this.app.workspace.on("active-leaf-change", this.leafChangeListeners);, this.app.vault.off("delete", this.fileDeleteListener);, this.app.workspace.off("active-leaf-change", this.leafChangeListeners);, const createFileEventRef = app.vault.on("create", async (file: TFile) => {, const deleteFileEventRef = app.vault.on("delete", (file: TFile) => {, const renameFileEventRef = app.vault.on("rename", async (file: TFile, oldPath: string) => {, const modifyFileEventRef = app.vault.on("modify", async (file: TFile) => {, this.eventRefs.forEach(ref => { Events need to be registered, so they can be properly unloaded when the plugin is disabled. https://docs.obsidian.md/Plugins/Events The relevant classes should extend the Component or similar class, and it's parent should call .addChild() so the parent can manage it's lifecycle.
• console.info("script extension created " + file.path), console.info("script extension deleted " + file.path), console.info("script extension modified " + file.path, extension), console.info("script extension renamed " + oldPath + " to " + file.path), onsole.info("script extension loaded " + this.formScripts.size + " functions from " + this.extensionFolder, this.formScripts); Please avoid unnecessary logging. If you need it for debugging purposes, add a check to only log during development.
• .getAllLoadedFiles() You can use Vault.getAllFolder() instead of getting all loaded files and then filtering down to just folders.
• .getAllLoadedFiles() You can use Vault.getFiles() instead of getting all loaded files and then filtering down to just files.
• Please consider using Notice instead of your own custom Toast implementation.

[RavenHogWarts]

1,2,4,9 可以直接删改

[RavenHogWarts]

done

[RavenHogWarts]

3 可以把 plugin 里的 manifest 删了，然后 workflows 里文件路径改一下

[RavenHogWarts]

done