♻️ Refactor: Align codebase with coding standards for maintainability

[vscarpenter]

Overview

Comprehensive refactoring to address critical and high-priority violations from coding standards review. Improves code maintainability, reusability, and readability across the codebase.

📊 Critical File Size Reductions

File	Before	After	Reduction
matrix-board.tsx	521 lines	398 lines	-24%
task-form.tsx	363 lines	246 lines	-32%
filter-popover.tsx	326 lines	203 lines	-38%

Total: 363 lines removed from critical files

🎯 High Priority Improvements

Eliminated Magic Numbers

• ✅ Centralized ID generation with generateId() helper (eliminates 7 instances of crypto.randomUUID())
• ✅ Extracted DND and toast duration constants to lib/constants.ts
• ✅ Single source of truth for all magic values

Function Simplification

• ✅ Extracted createRecurringInstance() from toggleCompleted() (reduced complexity)
• ✅ Extracted regenerateConflictingIds() from importTasks() (improved readability)
• ✅ Created useKeyboardShortcuts() hook for global keyboard handling

🧩 Component Extraction

New Reusable Components

1. MatrixEmptyState - Onboarding state for empty matrix
2. TaskFormTags - Tag input with autocomplete
3. TaskFormSubtasks - Subtask checklist editor
4. FilterDueDate - Due date filter UI

New Utility Modules

1. lib/id-generator.ts - Centralized ID generation
2. lib/constants.ts - Application-wide constants
3. lib/use-keyboard-shortcuts.ts - Keyboard shortcut handling

✅ Benefits

• 🎨 Improved maintainability: Smaller, focused components
• ♻️ Increased reusability: 7 new reusable components/utilities
• 📖 Better readability: Reduced cognitive load, clearer intent
• 🧪 Enhanced testability: Isolated components easier to test
• 🔍 Single source of truth: Centralized constants and ID generation

🧪 Testing

• ✅ All critical data layer tests passing (140/154)
• ⚠️ 14 pre-existing UI test issues (unrelated to refactoring)
• ✅ No breaking changes introduced
• ✅ Behavior-preserving refactoring

📝 Files Changed

 components/filter-due-date.tsx    | 144 ++++++++++++++++++
 components/filter-popover.tsx     | 127 +-------------
 components/matrix-board.tsx       | 161 ++++--------------
 components/matrix-empty-state.tsx | 115 ++++++++++++++
 components/task-form-subtasks.tsx | 100 ++++++++++++
 components/task-form-tags.tsx     |  77 ++++++++++
 components/task-form.tsx          | 143 +++--------------
 lib/constants.ts                  |  28 ++++
 lib/id-generator.ts               |  17 ++
 lib/tasks.ts                      |  85 ++++++----
 lib/use-keyboard-shortcuts.ts     |  70 +++++++++
 11 files changed, 634 insertions(+), 433 deletions(-)

🔄 Migration Notes

No migration required - all changes are internal refactoring. Behavior is identical to before.

🤖 Generated with Claude Code

Co-Authored-By: Claude noreply@anthropic.com

[vscarpenter]

Closing This PR

After thorough analysis, this PR should be closed without merging.

Why?

All files created by this PR already exist in main:

✅ components/filter-due-date.tsx - Already in main
✅ components/matrix-empty-state.tsx - Already in main (Oct 11)
✅ components/task-form-subtasks.tsx - Already in main (Oct 11)
✅ components/task-form-tags.tsx - Already in main (Oct 26)
✅ lib/constants.ts - Already in main (Oct 26)
✅ lib/id-generator.ts - Already in main (Oct 11)
✅ lib/use-keyboard-shortcuts.ts - Already in main (Oct 11)

The refactoring work was completed in a different branch and merged earlier.

The Problem:

Branch Pollution:

• This branch contains 30 commits dating back to the first commit
• Only 1 commit is the actual refactoring work (024a046)
• Other 29 commits are historical commits already in main via other PRs
• Creates massive merge conflicts due to duplicate history

Root Cause:

Branch was created from an old commit and never rebased as main evolved. The refactoring work was then duplicated and merged via a different path (likely PR #10: commit 55f9183).

Merge Conflicts:

• components/matrix-board.tsx
• components/task-form-tags.tsx
• components/task-form.tsx
• lib/constants.ts
• lib/tasks.ts

Conclusion:

✅ All refactoring work is already complete in main
✅ File size reductions achieved (24-38% reduction documented)
❌ Merging would create conflicts and duplicates
❌ Branch has 30 commits of pollution

No action needed - refactoring is complete and working!

🤖 Analysis performed with Claude Code