Fixed the LookAt handling of offset and origin.

robertosfield · robertosfield · commit 7e6c315a09c5 · 2024-11-15T11:57:38.000Z
diff --git a/src/vsg/app/ViewMatrix.cpp b/src/vsg/app/ViewMatrix.cpp
@@ -50,7 +50,8 @@ void LookAt::set(const dmat4& matrix)
 
 dmat4 LookAt::transform(const vsg::dvec3& offset) const
 {
-    return lookAt(eye, center, up) * vsg::translate(offset-origin);
+    dvec3 delta = origin - offset;
+    return lookAt(eye + delta, center + delta, up);
 }
 
 dmat4 RelativeViewMatrix::transform(const vsg::dvec3& offset) const

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,8 @@ void LookAt::set(const dmat4& matrix)`
`50`	`50`
`51`	`51`	`dmat4 LookAt::transform(const vsg::dvec3& offset) const`
`52`	`52`	`{`
`53`		`- return lookAt(eye, center, up) * vsg::translate(offset-origin);`
	`53`	`+ dvec3 delta = origin - offset;`
	`54`	`+ return lookAt(eye + delta, center + delta, up);`
`54`	`55`	`}`
`55`	`56`
`56`	`57`	`dmat4 RelativeViewMatrix::transform(const vsg::dvec3& offset) const`