Skip to content

Commit eb0bfc3

Browse files
committed
Flipped the order of the vertexOffset parameter to match the ordering in DrawIndexed/vkCmdDrawIndexed.
1 parent 3b4dfd1 commit eb0bfc3

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

include/vsg/utils/ComputeBounds.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ namespace vsg
7171
void apply(const uintArray& array) override;
7272

7373
virtual void applyDraw(uint32_t firstVertex, uint32_t vertexCount, uint32_t firstInstance, uint32_t instanceCount);
74-
virtual void applyDrawIndexed(uint32_t firstIndex, uint32_t indexCount, uint32_t firstInstance, uint32_t instanceCount, uint32_t vertexOffset);
74+
virtual void applyDrawIndexed(uint32_t firstIndex, uint32_t indexCount, uint32_t firstInstance, uint32_t vertexOffset, uint32_t instanceCount);
7575

7676
void add(const dbox& bb);
7777
void add(const dsphere& bs);

src/vsg/utils/ComputeBounds.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ void ComputeBounds::apply(const vsg::VertexIndexDraw& vid)
145145

146146
if (vid.indices) vid.indices->accept(*this);
147147

148-
applyDrawIndexed(vid.firstIndex, vid.indexCount, vid.firstInstance, vid.instanceCount, vid.vertexOffset);
148+
applyDrawIndexed(vid.firstIndex, vid.indexCount, vid.firstInstance, vid.vertexOffset, vid.instanceCount);
149149
}
150150

151151
void ComputeBounds::apply(const vsg::InstanceNode& in)
@@ -177,7 +177,7 @@ void ComputeBounds::apply(const vsg::InstanceDrawIndexed& idi)
177177
arrayState.apply(idi);
178178

179179
idi.indices->accept(*this);
180-
applyDrawIndexed(idi.firstIndex, idi.indexCount, instanceNode->firstInstance, instanceNode->instanceCount, idi.vertexOffset);
180+
applyDrawIndexed(idi.firstIndex, idi.indexCount, instanceNode->firstInstance, idi.vertexOffset, instanceNode->instanceCount);
181181
}
182182

183183
void ComputeBounds::apply(const vsg::BindVertexBuffers& bvb)
@@ -219,7 +219,7 @@ void ComputeBounds::apply(const Draw& draw)
219219

220220
void ComputeBounds::apply(const DrawIndexed& drawIndexed)
221221
{
222-
applyDrawIndexed(drawIndexed.firstIndex, drawIndexed.indexCount, drawIndexed.firstInstance, drawIndexed.instanceCount, drawIndexed.vertexOffset);
222+
applyDrawIndexed(drawIndexed.firstIndex, drawIndexed.indexCount, drawIndexed.firstInstance, drawIndexed.vertexOffset, drawIndexed.instanceCount);
223223
};
224224

225225
void ComputeBounds::applyDraw(uint32_t firstVertex, uint32_t vertexCount, uint32_t firstInstance, uint32_t instanceCount)
@@ -242,7 +242,7 @@ void ComputeBounds::applyDraw(uint32_t firstVertex, uint32_t vertexCount, uint32
242242
}
243243
}
244244

245-
void ComputeBounds::applyDrawIndexed(uint32_t firstIndex, uint32_t indexCount, uint32_t firstInstance, uint32_t instanceCount, uint32_t vertexOffset)
245+
void ComputeBounds::applyDrawIndexed(uint32_t firstIndex, uint32_t indexCount, uint32_t firstInstance, uint32_t vertexOffset, uint32_t instanceCount)
246246
{
247247
auto& arrayState = *arrayStateStack.back();
248248
uint32_t lastIndex = instanceCount > 1 ? (firstInstance + instanceCount) : firstInstance + 1;

0 commit comments

Comments
 (0)