Cleaning up gcc warnings

[theodoregoetz]

Hi @robertosfield , I'd like to make a sweep through the VSG code to clear out all the warnings I'm getting from gcc (v13.2.1). Currently, when compiling against VSG as a git submodule, I have put this at the top of my own cmake file:

set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-sign-conversion -Wno-overloaded-virtual -Wno-extra-semi -Wno-float-equal -Wno-float-conversion -Wno-double-promotion -Wno-old-style-cast -Wno-cast-qual -Wno-conversion -Wno-undef -Wno-overflow -Wno-format-nonliteral -Wno-format")

which is not ideal. I'm more than willing to clean these up in a PR unless you would rather be in control of this change.

I would also like to add the following to top of VSG's cmake file:

if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
  set(CMAKE_CXX_FLAGS "-fstack-protector-strong -fcf-protection=full -fstack-clash-protection -Wall -Wextra -Wpedantic -Wconversion -Wsign-conversion -Wcast-qual -Wformat=2 -Wundef -Werror=float-equal -Wshadow -Wcast-align -Wunused -Wnull-dereference -Wdouble-promotion -Wimplicit-fallthrough -Wextra-semi -Woverloaded-virtual -Wnon-virtual-dtor -Wold-style-cast ${CMAKE_CXX_FLAGS}")
  set(CMAKE_CXX_FLAGS_RELEASE "-O3 -DNDEBUG -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 ${CMAKE_CXX_FLAGS_RELEASE}")
  set(CMAKE_EXE_LINKER_FLAGS "-Wl,--allow-shlib-undefined,--as-needed,-z,noexecstack,-z,relro,-z,now ${CMAKE_EXE_LINKER_FLAGS}")
  set(CMAKE_SHARED_LINKER_FLAGS "-Wl,--allow-shlib-undefined,--as-needed,-z,noexecstack,-z,relro,-z,now ${CMAKE_SHARED_LINKER_FLAGS}")
endif ()

This is equivalent to what the current version of cmake-init produces in the CMakePresets.json file for the gcc/clang presets.

[theodoregoetz]

Of course, I'd do that latter part in the vsg_setup_build_vars() method in the vsgMacros.cmake file.